Document loader.withCredentials for asset loading#1070
Open
mvaligursky wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
!!!!! MERGE WHEN ENGINE 2.21 IS RELEASED !!!!!
Documents the new
ResourceLoader.withCredentialsoption for loading assets from an authenticated cross-origin host. Engine support: playcanvas/engine#8983.Changes:
app.loader.withCredentials = trueopt-in, the requirement to set it before assets load, and the server-side CORS requirements (non-wildcardAccess-Control-Allow-Origin+Access-Control-Allow-Credentials: true).Note: the corresponding Editor project setting is tracked separately in playcanvas/editor#2132 and is intentionally not documented here until that UI ships.