Conversation
idy
force-pushed
the
fix/stream-reset-complete
branch
from
September 20, 2026 14:50
0e1ea69 to
ba85306
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 85.52% 85.63% +0.10%
==========================================
Files 56 56
Lines 5487 5508 +21
==========================================
+ Hits 4693 4717 +24
+ Misses 559 556 -3
Partials 235 235
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JoTurk
reviewed
Sep 20, 2026
idy
force-pushed
the
fix/stream-reset-complete
branch
from
September 20, 2026 15:40
ba85306 to
1c6e67e
Compare
An application that reuses stream identifiers, such as WebRTC data channels, has no way to learn when a stream's reset has finished. Reusing the identifier earlier lets a late reset request or response for the old stream act on the new one. Add OnStreamResetComplete. The handler is called once per stream, after the stream has been removed and both the incoming reset from the peer and the acknowledgement of our own outgoing reset have arrived, so the identifier can safely be reused. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
idy
force-pushed
the
fix/stream-reset-complete
branch
from
September 21, 2026 18:35
1c6e67e to
76e06ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applications that reuse stream IDs (WebRTC data channels) cannot tell when a reset has finished, and reusing an ID too early lets late reset traffic for the old stream hit the new one. This adds OnStreamResetComplete, called once after both the incoming and outgoing resets are done and the stream is removed.
Split out of #494; overlaps with #463.
🤖 Generated with Claude Code