Conversation
idy
force-pushed
the
fix/serialize-stream-resets
branch
from
September 20, 2026 14:49
9dec012 to
2afccee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
==========================================
+ Coverage 85.52% 85.67% +0.14%
==========================================
Files 56 56
Lines 5487 5493 +6
==========================================
+ Hits 4693 4706 +13
+ Misses 559 553 -6
+ Partials 235 234 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RFC 6525 section 5.1.1 permits only one reconfiguration request in flight. Stream.Close for several streams in a row sent one RECONFIG per call, each with its own RSN, before the previous one was answered. If the packets were reordered, the later request arrived first and the earlier one was rejected with Bad Sequence Number, so that stream was never reset. Queue outgoing stream resets and send the next request only after the outstanding one is answered. Cap a request at 128 stream identifiers so the RECONFIG chunk fits in one packet. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
idy
force-pushed
the
fix/serialize-stream-resets
branch
from
September 21, 2026 18:34
2afccee to
1bdb2f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing several streams in a row sends one RECONFIG per stream before the previous one is answered. RFC 6525 section 5.1.1 allows only one request in flight; if the packets are reordered, the earlier request gets Bad Sequence Number and that stream is never reset. This queues resets, sends the next request after the outstanding one is answered, and caps a request at 128 stream IDs so it fits in one packet.
Split out of #494.
🤖 Generated with Claude Code