Keep stream ownership for delayed ACKs - #507
Merged
Merged
Conversation
Member
|
thank you for breaking the PRs i'll get most of them reviewed tonight |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #507 +/- ##
=======================================
Coverage 85.48% 85.48%
=======================================
Files 56 56
Lines 5484 5484
=======================================
Hits 4688 4688
Misses 560 560
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Thanks for reviewing, and thanks for not turning away AI-assisted contributions! 😄 The way I see it, I'm burning my own Fable 5.1 tokens to send fixes your way, so it's basically a roundabout donation to open source. Win-win! |
processSelectiveAck summed acknowledged bytes per stream identifier and looked the stream up by identifier afterwards. When a stream is reset and its identifier is reused before a delayed SACK for the old stream arrives, the bytes were credited to the new stream, releasing buffered bytes it never sent. Record the sending stream on each DATA chunk and credit the bytes to that stream. A stream that has already been removed is skipped. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
idy
force-pushed
the
fix/delayed-ack-stream-owner
branch
from
September 16, 2026 15:48
def4073 to
4ef4edf
Compare
Member
|
Would love if these PRs reference which part of the spec they enforce or implement :) |
Member
idy
added a commit
to GizClaw/pion-sctp
that referenced
this pull request
Sep 20, 2026
Bring in upstream sctp cb39bd6, which includes ClientContext, the move to transport/v5 and two fixes from this branch that upstream merged (pion#495 duplicate INIT, pion#507 stream ownership for delayed ACKs). Resolve the checkPartialReliabilityStatus conflict by keeping this branch's per-chunk reliability policy, which survives the peer resetting its outgoing stream, while adopting upstream's corrected retransmission count (nSent > limit, RFC 7496 Sec 3.1). Update this branch's own tests to transport/v5. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a stream is reset and its ID is reused before a delayed SACK for the old stream arrives, the acknowledged bytes are credited to the new stream and release buffered bytes it never sent. This records the sending stream on each DATA chunk and credits that stream.
Split out of #494.
🤖 Generated with Claude Code