Skip to content

fix(server): strip positions from file manager targets - #5850

Closed
davisonio wants to merge 1 commit into
pingdotgg:mainfrom
davisonio:fix/file-manager-positioned-paths
Closed

fix(server): strip positions from file manager targets#5850
davisonio wants to merge 1 commit into
pingdotgg:mainfrom
davisonio:fix/file-manager-positioned-paths

Conversation

@davisonio

Copy link
Copy Markdown

What Changed

  • Strip parsed :line[:column] positions before launching a target with the file manager.
  • Add regression coverage for plain paths, line targets, and line-and-column targets on macOS.

Why

Markdown file links encode editor positions in the launch target. Command editors understand that syntax, but the file-manager path currently passes it unchanged to open, explorer, or xdg-open. The operating system then receives a nonexistent path such as /Users/tester/.claude/CLAUDE.md:4, so the click can appear to do nothing.

The normalization is in the server launcher because that is where the selected launch integration is known. It reuses the existing target parser and leaves plain paths unchanged.

This is narrower than #681, which combined suffix stripping with editor fallback behavior. It is also separate from #5366, which adds a new Open in folder action. This PR fixes the existing primary Open in editor action when File Manager is the preferred integration.

Verification

  • vp test run apps/server/src/process/externalLauncher.test.ts
  • vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
  • vp lint apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
  • vp run --filter t3 typecheck

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • No UI code changed
  • No animation or interaction recording is required

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 722175f0-a3ca-459f-85f5-224005190899

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@davisonio davisonio closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant