fix(server): strip positions from file manager targets - #5850
Closed
davisonio wants to merge 1 commit into
Closed
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
:line[:column]positions before launching a target with the file manager.Why
Markdown file links encode editor positions in the launch target. Command editors understand that syntax, but the file-manager path currently passes it unchanged to
open,explorer, orxdg-open. The operating system then receives a nonexistent path such as/Users/tester/.claude/CLAUDE.md:4, so the click can appear to do nothing.The normalization is in the server launcher because that is where the selected launch integration is known. It reuses the existing target parser and leaves plain paths unchanged.
This is narrower than #681, which combined suffix stripping with editor fallback behavior. It is also separate from #5366, which adds a new Open in folder action. This PR fixes the existing primary Open in editor action when File Manager is the preferred integration.
Verification
vp test run apps/server/src/process/externalLauncher.test.tsvp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.tsvp lint apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.tsvp run --filter t3 typecheckChecklist