Skip to content

fix(mobile): use glass for pending cards - #5466

Closed
t3-code[bot] wants to merge 2 commits into
mainfrom
t3bot/mobile-pending-card-glass-pr
Closed

fix(mobile): use glass for pending cards#5466
t3-code[bot] wants to merge 2 commits into
mainfrom
t3bot/mobile-pending-card-glass-pr

Conversation

@t3-code

@t3-code t3-code Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

What Changed

  • use native Liquid Glass for pending approval and user-input cards on supported iOS
  • keep an opaque fallback on unsupported platforms so thread content cannot bleed through

Why

This is an alternative implementation for #5450. Pending request cards should follow the current mobile glass surface pattern used by the composer instead of becoming opaque everywhere.

UI Changes

Captured from the real mobile showcase route on an iPhone 6.9-inch simulator in dark mode.

Before After
Pending user-input card before Pending user-input card with Liquid Glass

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes (not applicable, no motion changes)

Model: GPT-5.4. Harness: T3 Code.


Note

Low Risk
UI-only styling and animation tweaks for thread pending cards; no business logic, auth, or data handling changes.

Overview
Pending approval and user-input cards in the thread composer overlay now share a new PendingCardSurface wrapper instead of inline semi-transparent bordered Views.

On iOS where Liquid Glass is supported, that surface uses LiquidGlassView with a regular effect and light/dark colorScheme, matching the composer’s glass pattern. Elsewhere it falls back to a fully opaque rounded neutral card so thread content does not show through.

ThreadDetailScreen skips the FadeInDown enter animation on the pending-cards stack when glass is supported, consistent with other glass overlays in the app.

Reviewed by Cursor Bugbot for commit c6d5104. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Use glass surface for pending cards in mobile thread detail

  • Adds a new PendingCardSurface component that renders a LiquidGlassView on supported platforms (with dark/light color scheme), falling back to a themed bordered View otherwise.
  • Updates PendingApprovalCard and PendingUserInputCard to use PendingCardSurface as their outer container.
  • Disables the FadeInDown entry animation for pending cards when LiquidGlass is supported in ThreadDetailScreen.
  • Behavioral Change: fallback card backgrounds no longer apply /80 opacity, and the entry animation is skipped on glass-supported platforms.

Macroscope summarized c6d5104.

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 6, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c892ac2. Configure here.

Comment thread apps/mobile/src/features/threads/PendingCardSurface.tsx
@macroscopeapp

macroscopeapp Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved c6d5104

Pure UI styling change that introduces a glass visual effect for pending cards on supported devices, with proper fallback. No business logic affected, just presentational wrapper extraction and visual polish.

You can customize Macroscope's approvability policy. Learn more.

@maria-rcks maria-rcks closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant