fix(mobile): use glass for pending cards - #5466
Closed
t3-code[bot] wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c892ac2. Configure here.
Contributor
ApprovabilityVerdict: Approved c6d5104 Pure UI styling change that introduces a glass visual effect for pending cards on supported devices, with proper fallback. No business logic affected, just presentational wrapper extraction and visual polish. You can customize Macroscope's approvability policy. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What Changed
Why
This is an alternative implementation for #5450. Pending request cards should follow the current mobile glass surface pattern used by the composer instead of becoming opaque everywhere.
UI Changes
Captured from the real mobile showcase route on an iPhone 6.9-inch simulator in dark mode.
Checklist
Model: GPT-5.4. Harness: T3 Code.
Note
Low Risk
UI-only styling and animation tweaks for thread pending cards; no business logic, auth, or data handling changes.
Overview
Pending approval and user-input cards in the thread composer overlay now share a new
PendingCardSurfacewrapper instead of inline semi-transparent borderedViews.On iOS where Liquid Glass is supported, that surface uses
LiquidGlassViewwith aregulareffect and light/darkcolorScheme, matching the composer’s glass pattern. Elsewhere it falls back to a fully opaque rounded neutral card so thread content does not show through.ThreadDetailScreenskips theFadeInDownenter animation on the pending-cards stack when glass is supported, consistent with other glass overlays in the app.Reviewed by Cursor Bugbot for commit c6d5104. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Use glass surface for pending cards in mobile thread detail
PendingCardSurfacecomponent that renders aLiquidGlassViewon supported platforms (with dark/light color scheme), falling back to a themed borderedViewotherwise.PendingApprovalCardandPendingUserInputCardto usePendingCardSurfaceas their outer container.FadeInDownentry animation for pending cards whenLiquidGlassis supported inThreadDetailScreen./80opacity, and the entry animation is skipped on glass-supported platforms.Macroscope summarized c6d5104.