Repository navigation
feat(web): preview archives, sqlite databases, and decoded images #21467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maria-rcks
wants to merge
5
commits into
t3/large-file-previews
Choose a base branch
from
t3/binary-file-previews
base: t3/large-file-previews
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,243
−146
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d34e168
feat(web): preview archives, sqlite databases, and decoded images
maria-rcks 26597b3
fix(web): keep binary previews lazy and align heif file icons
maria-rcks 1b88a01
fix(web): keep lazy image decoding compatible with react compiler
maria-rcks 98422ab
test(shared): cover binary file downloads across clients
maria-rcks 4e08914
chore: merge t3/large-file-previews
maria-rcks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -293,6 +293,7 @@ describe("pickProjectFavicon", () => { | |
| "gif", | ||
| "ico", | ||
| "heic", | ||
| "heif", | ||
| "jpeg", | ||
| "jpg", | ||
| "png", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { lazy, Suspense } from "react"; | ||
|
|
||
| import { FileSurfaceLoading } from "./fileSurfaceChrome"; | ||
|
|
||
| const BinaryViewer = lazy(() => import("./BinaryViewer")); | ||
|
|
||
| export function BinaryFilePreview(props: { | ||
| readonly src: string; | ||
| readonly name: string; | ||
| readonly kind: "archive" | "sqlite"; | ||
| }) { | ||
| return ( | ||
| <Suspense fallback={<FileSurfaceLoading />}> | ||
| <BinaryViewer key={props.src} {...props} /> | ||
| </Suspense> | ||
| ); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium
files/AttachmentFilePreview.tsx:281When an image fails to load,
PreviewImageshows its local failure surface instead of setting this component’serror, so the parentFileSurfaceFailureand its retry action never appear. Report image load failures throughsetErrorso retry can refresh the asset URL and reload the image.🚀 Reply "fix it for me" or copy this AI Prompt for your agent: