Skip to content

master: fix minor wording issues in backup-storages and top-sql docs#23227

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
qiancai:minor-wording-fixes-23225
Jul 10, 2026
Merged

master: fix minor wording issues in backup-storages and top-sql docs#23227
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
qiancai:minor-wording-fixes-23225

Conversation

@qiancai

@qiancai qiancai commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted?

  • br/backup-and-restore-storages.md: capitalize first letters of two list items describing GCS configuration (full -> Full, log -> Log)
  • dashboard/top-sql.md: add missing colon after **Note** in the admonition about TiKV Network IO collection

Which TiDB version(s) do your changes apply to?

  • master (the latest development version)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

- Capitalize first letters in list items for GCS configuration
- Add missing colon after "Note" in top-sql admonition

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2026
@qiancai qiancai self-assigned this Jul 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces minor capitalization and formatting improvements to the documentation, specifically capitalizing list items in the backup and restore storage guide and adding a colon to a note block in the Top SQL dashboard guide. The reviewer suggested further styling enhancements in the backup and restore guide, including capitalizing the instruction verb after the colon and correcting the linked document title to match the actual target page.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread br/backup-and-restore-storages.md
@qiancai qiancai added the translation/no-need No need to translate this PR. label Jul 8, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jul 8, 2026
@qiancai

qiancai commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

/approve

@qiancai qiancai added the lgtm label Jul 10, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jul 10, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 0c234d8 into pingcap:master Jul 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant