Skip to content

release-8.5.6: fix Dumpling MySQL 8.4 support wording#23223

Open
yahonda wants to merge 1 commit into
pingcap:release-8.5from
yahonda:fix-en-dumpling-mysql84
Open

release-8.5.6: fix Dumpling MySQL 8.4 support wording#23223
yahonda wants to merge 1 commit into
pingcap:release-8.5from
yahonda:fix-en-dumpling-mysql84

Conversation

@yahonda

@yahonda yahonda commented Jul 8, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fix inaccurate English wording in release-8.5.6.md. Changed "updated MySQL binary log terminology" to "updated MySQL binary log naming" to match the Chinese original "二进制日志命名" (binary log naming).

The inaccurate English wording "terminology" caused the Japanese translation to use "用語" (terminology), which sounds unnatural in Japanese. The Chinese original "命名" (naming) is more specific to binary log naming conventions. This fix will also correct the downstream Japanese translation when the weekly diff translation runs.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

'terminology' was an inaccurate translation of the Chinese original
'二进制日志命名' (binary log naming). Change to 'naming' for accuracy.
@ti-chi-bot

ti-chi-bot Bot commented Jul 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant