Skip to content

test: remove smoke-test fixture (12.7)#4

Merged
nabeelio merged 1 commit into
mainfrom
smoke-test/remove
May 5, 2026
Merged

test: remove smoke-test fixture (12.7)#4
nabeelio merged 1 commit into
mainfrom
smoke-test/remove

Conversation

@nabeelio

@nabeelio nabeelio commented May 5, 2026

Copy link
Copy Markdown
Member

Final cleanup of the bootstrap smoke test. Removes packages/phpvms/smoke-test.yml and verifies the index rebuilds without it.

@coderabbitai

coderabbitai Bot commented May 5, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@nabeelio has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 8 seconds before requesting another review.

To unlock additional reviews beyond the hourly cap, upgrade to Pro or higher. Account admins can upgrade under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Free

Run ID: 4ec38028-a593-4b5e-8499-0996705da26b

📥 Commits

Reviewing files that changed from the base of the PR and between 129a753 and 53704c2.

📒 Files selected for processing (1)
  • packages/phpvms/smoke-test.yml

Walkthrough

A YAML smoke-test fixture file for phpvms was deleted, removing its package metadata, runtime requirements (PHP ^8.2, phpvms ^7.0), version 0.1.0 release information including zip artifact coordinates and SHA256, and its revocation status.

Changes

Fixture Removal

Layer / File(s) Summary
Fixture Definition
packages/phpvms/smoke-test.yml
The entire phpvms smoke-test YAML fixture is removed, including metadata (name, description, category, license, keywords), requirements (php: ^8.2, phpvms: ^7.0), release info (v0.1.0, zip_url, sha256, published_at), and revocation flags.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through code so light,
One fixture file takes its flight,
Smoke clears away, simplicity wins,
The cleanup dance now begins! 🐰✨


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@phpvms-registry-bot

Copy link
Copy Markdown
Contributor

Registry validation: failed

[FAIL] packages/phpvms/smoke-test.yml

Issues:

  • yaml-parse — Failed to parse YAML: ENOENT: no such file or directory, open '/home/runner/work/addon-registry/addon-registry/packages/phpvms/smoke-test.yml'

nabeelio added a commit that referenced this pull request May 5, 2026
Without --diff-filter the validator picks up paths the PR removed and
crashes with ENOENT in runPackageChecks when it tries to read them.
Use --diff-filter=ACMRT so deleted entries never reach the checker;
renamed/copied entries surface their new path which is what we want
to validate.

Refactor changedYamlFiles into a pure filterPackageYamlPaths helper
so we can unit-test the path filter without a git repo. Also gate
main() on direct execution so the test file can import the helper
without the script auto-running.

Caught while exercising task 12.7 of bootstrap-addon-registry: the
smoke-test fixture removal PR (#4) failed validation with the ENOENT
crash described above.
Final smoke-test step. After merge, publish.yml should rebuild the
index without phpvms/smoke-test, leaving raw/packages.json empty (no
other packages are registered yet).
@nabeelio nabeelio force-pushed the smoke-test/remove branch from 129a753 to 53704c2 Compare May 5, 2026 01:42
@nabeelio nabeelio merged commit ba0cdbd into main May 5, 2026
3 checks passed
@nabeelio nabeelio deleted the smoke-test/remove branch May 5, 2026 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant