Repository navigation
fix(middleware): guard ConvertCsvMiddleware against absent params - #17
Merged
Merged
Conversation
explode(null) is deprecated on PHP 8.1+ and logged on every request where the optional CSV param is absent (surfaced by WordPress REST permission-callback derivation running the middleware under WP_DEBUG). Absent or empty params convert to an empty list — the same result the explode()+filter pipeline always produced. Bumps version to 2.1.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
explode(null) deprecation fired on every request without the optional CSV param. Behavior-preserving: absent/empty input still converts to an empty list. Verified via standalone exercise (repo test bootstrap is broken pre-existing — ValidateCITest references a nonexistent PHPNomad\Core\Tests\TestCase) and end-to-end by Siren's fresh-install smoke walk.