Repository navigation
Conversation
…bject `ct_eval_isset_dim()` treated partial objects like scalars and folded the result to false/true. But using an object as an array either calls `ArrayAccess::offsetExists()` or throws an Error.
arnaud-lb
approved these changes
Oct 5, 2026
| } else if (IS_PARTIAL_OBJECT(op1)) { | ||
| /* Objects may implement ArrayAccess or throw. */ | ||
| return FAILURE; | ||
| } else { |
Member
There was a problem hiding this comment.
We could add an assertion here to check that op1 is actually a scalar.
It looks like that ct_eval_isset_dim() pre-dates IS_PARTIAL_OBJECT and we forgot to update it when introducing IS_PARTIAL_OBJECT. An assertion would have spotted the issue earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ct_eval_isset_dim()treated partial objects like scalars and folded the result to false/true. But using an object as an array either callsArrayAccess::offsetExists()or throws an Error.