Conversation
The fallback added in php#23825 tested the atomic flag twice on every wait, since the compiler cannot assume it did not change in between, and marked the epoll_wait() path unexpected although it is taken on every wait once the kernel has answered ENOSYS. The two calls are now the branches of one if/else with a goto from the ENOSYS case into the fallback branch, and the branch hints are gone.
TimWolla
approved these changes
Sep 30, 2026
TimWolla
left a comment
TimWolla
left a comment
Member
There was a problem hiding this comment.
Thank you! Could possibly avoid the duplicated epoll_wait() duplication with some creative brace placement.
Member
Author
I tried it but it was a bit ugly... :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback added in #23825 tested the atomic flag twice on every wait, since the compiler cannot assume it did not change in between, and marked the epoll_wait() path unexpected although it is taken on every wait once the kernel has answered ENOSYS. The two calls are now the branches of one if/else with a goto from the ENOSYS case into the fallback branch, and the branch hints are gone.