Skip to content

GH-23686: SOAP: redact more headers by default, add keep_headers option - #23698

Open
DanielEScherzer wants to merge 4 commits into
php:PHP-8.6from
DanielEScherzer:WSDL-credentials
Open

DanielEScherzer wants to merge 4 commits into
php:PHP-8.6from
DanielEScherzer:WSDL-credentials

Conversation

@DanielEScherzer

Copy link
Copy Markdown
Member

No description provided.

@DanielEScherzer

Copy link
Copy Markdown
Member Author

@php/release-managers-86 can you please let me know if this needs to be in by the branch cut? I'm unsure if this counts as a new feature that would be blocked by the feature freeze - it adds more options, but the motivation is to allow opting out of the bug fix

@DanielEScherzer

This comment was marked as resolved.

@DanielEScherzer

This comment was marked as resolved.

Comment thread ext/soap/tests/gh23686/check_headers.inc Outdated
@svpernova09

Copy link
Copy Markdown
Contributor

@mbeccati and I agree this can go into 8.6

@DanielEScherzer
DanielEScherzer changed the base branch from master to PHP-8.6 September 28, 2026 04:38
@DanielEScherzer
DanielEScherzer marked this pull request as ready for review September 28, 2026 04:38
@DanielEScherzer

Copy link
Copy Markdown
Member Author

This should be ready for review, ideally we should merge it in the next two weeks so that it is in RC3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SoapClient only strips Authorization: Basic when a WSDL imports from another host

3 participants