Drop unused class_cleanup_handlers - #23696
Merged
Merged
Conversation
This is only ever written to, but never read, and since this is static, no other translation unit or module can access this too.
Girgias
reviewed
Sep 15, 2026
Comment on lines
-2613
to
-2619
| /* Collect internal classes with static members */ | ||
| ZEND_HASH_MAP_FOREACH_PTR(CG(class_table), ce) { | ||
| if (ce->type == ZEND_INTERNAL_CLASS && | ||
| ce->default_static_members_count > 0) { | ||
| class_count++; | ||
| } | ||
| } ZEND_HASH_FOREACH_END(); |
Member
Author
There was a problem hiding this comment.
Because the class_count variable was only used for class_cleanup_handlers
Girgias
reviewed
Sep 15, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
I'm confused by what that code is actually doing, it seems to handle something that needs to be possibly handled (static properties(?)) but in the most bizarre way
Member
Author
Once upon a time, some static memory needed explicit freeing. It no longer does now, that code was removed, but the code that builds the |
Girgias
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only ever written to, but never read, and since this is static, no other translation unit or module can access this too.