UPGRADING: document the unpack() element name BC break - #23446
Merged
alexandre-daubois merged 2 commits intoAug 25, 2026
Merged
Conversation
LamentXU123
approved these changes
Aug 25, 2026
Member
|
I would also suggest to add test cases since this is confirmed behavior :) |
alexandre-daubois
changed the title
A "<" or ">" directly following a format code is now consumed as an endianness modifier, so unpack() element names starting with either character resolve differently or throw.
alexandre-daubois
force-pushed
the
upgrading-pack-unpack-endianness-bc
branch
from
August 25, 2026 09:35
57ec95f to
3de5b05
Compare
Member
Author
|
Ah yes, forgot about them! Tests added in the last commit |
LamentXU123
reviewed
Aug 25, 2026
alexandre-daubois
force-pushed
the
upgrading-pack-unpack-endianness-bc
branch
from
August 25, 2026 09:44
3de5b05 to
fd4405c
Compare
Cover the positions where a "<" or ">" is read as a modifier and where it stays part of the element name, with the error cases split out.
alexandre-daubois
force-pushed
the
upgrading-pack-unpack-endianness-bc
branch
from
August 25, 2026 09:52
fd4405c to
bab83d8
Compare
LamentXU123
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A "<" or ">" directly following a format code is now consumed as an endianness modifier, so unpack() element names starting with either character resolve differently or throw.
Spotted here: #21074 (comment)
I think the feature is niche enough to drop support of a name starting with a chevron, which is really unlikely to happen.