Fix wrong argument number in fsockopen/pfsockopen timeout error - #23338
Open
lacatoire wants to merge 1 commit into
Open
Fix wrong argument number in fsockopen/pfsockopen timeout error#23338lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
php_fsockopen_stream() called zend_argument_value_error(6, ...) for the $timeout parameter, but $timeout is the 5th argument. This caused the error message to show "Argument php#6" with no parameter name, since get_function_arg_name() returns NULL when arg_num exceeds the actual argument count. Reproduce: fsockopen('localhost', 80, $err, $errstr, -2.0); // Before: ValueError: fsockopen(): Argument php#6 must be -1 or between... // After: ValueError: fsockopen(): Argument php#5 ($timeout) must be -1...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_fsockopen_stream()calledzend_argument_value_error(6, ...)for the$timeoutparameter, but$timeoutis the 5th argument. Becauseget_function_arg_name(func, arg_num)returnsNULLwhenarg_numexceeds the actual argument count, the error message reported the wrong number and dropped the parameter name.Before:
After:
The same fix applies to
pfsockopen(), which delegates to the same internal helper.A regression test is included; it does not require network connectivity since the
ValueErroris raised before any connection attempt.