JSON: Add opt-in comments and trailing comma flags - #23336
Draft
otar wants to merge 2 commits into
Draft
Conversation
otar
marked this pull request as draft
August 17, 2026 17:08
Author
|
Sorry @bukka and @kocsismate, I accidentally tagged you on this PR. Please ignore this draft... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration files often use a narrow JSON extension with JS-style comments, trailing commas, or both. PHP currently requires a separate parser or a string-aware preprocessing pass. This PR adds native parser support. Strict JSON remains the default.
Public API
JSON_ALLOW_COMMENTS1 << 23json_decode(),json_validate()//and non-nesting/* ... */comments at JSON whitespace boundaries.JSON_ALLOW_TRAILING_COMMAS1 << 24json_decode(),json_validate()The flags are independent. Neither flag applies to
json_encode()or is enabled by default.Semantics
*/.JSON_INVALID_UTF8_IGNORE, but notJSON_INVALID_UTF8_SUBSTITUTE.JSON_ERROR_SYNTAXat the opening slash.[,],{,}, and[1,,]remain invalid.