More curl tests

[Sjord]

No description provided.

[Sjord]

@NickSdot Could you take a look at this?

[NickSdot]

Cannot really judge in detail what's tested, but found some things worth pointing out. Also, can confirm that this closes coverage gaps. ✌️

Coverage: ext/curl

Base: c621cbe27ffe59ed98228724d674dcadcf7f6e8d upstream/master
Tree: 2aa80efcacc776c87712a9beed9487c40be6cffc working tree

+--------+-------+---------+--------------------+-------------------+--------+---------+
|        | Tests | Sources |              Lines |          Branches |   Time |  Memory |
+--------+-------+---------+--------------------+-------------------+--------+---------+
| Base   |   189 |       6 | 2520/2912 (86.54%) | 847/4640 (18.25%) | 64.23s | 45.5 MB |
| Tree   |   197 |       6 | 2538/2912 (87.16%) | 857/4640 (18.47%) | 68.17s | 45.1 MB |
| Change |    +8 |       0 |  +18 / -0 (+0.62%) | +10 / -0 (+0.22%) | +3.94s | -0.4 MB |
+--------+-------+---------+--------------------+-------------------+--------+---------+

[NickSdot]

Could be one echo

[NickSdot]

PHP_EOL -> \n everywhere.

Alternatively, maybe you want to make the test less noisy by doing something like:

function do_redirect(string $label, int $code, ?int $postredir = null): void
{
    global $host;
    // curl stuff
    echo $label, ': ', trim(curl_exec($ch)), "\n";
}

foreach ([
    ['default 303', 303],
    ['301 on, code 301', 301, CURL_REDIR_POST_301],
    ['301 on, code 302', 302, CURL_REDIR_POST_301],
] as $case) {
    do_redirect(...$case);
}

[NickSdot]

Not sure what's up there, but this test says CURLOPT_SSH_HOSTKEYFUNCTION cannot be properly tested. But others do test it; looks like it needs at least a version gate in SKIPIF?

[Sjord]

I added the version check.

@Girgias Do you have any insight into why CURLOPT_SSH_HOSTKEYFUNCTION cannot be properly tested?

[NickSdot]

Version gate in SKIPIF?

php-src/ext/curl/curl.stub.php

Lines 1449 to 1454 in c621cbe

	/* Available since 7.11.1 */
	/**
	* @var int
	* @cvalue CURLOPT_MAXFILESIZE_LARGE
	*/
	const CURLOPT_MAXFILESIZE_LARGE = UNKNOWN;

[Sjord]

The minimum curl version PHP can be built with is 7.61, so CURLOPT_MAXFILESIZE_LARGE is always available.

[NickSdot]

But then the responder needs a case for this test that sends content length.

[NickSdot]

Could be one echo

[NickSdot]

Should be in --CLEAN--, eg:

--CLEAN--
<?php @unlink(sys_get_temp_dir() . '/curl_setopt_CURLOPT_WRITEHEADER.tmp'); ?>

requires to drop tempnam from $header_file, too.

--FILE--
$header_file = sys_get_temp_dir() . '/curl_setopt_CURLOPT_WRITEHEADER.tmp';

[NickSdot]

Suggested change

	echo curl_exec($ch);
	var_dump(in_array('README.*', $seen_patterns));
	var_dump(in_array('README.html', $seen_fnames));
	?>
	--EXPECT--
	The list of Debian mirror sites is available here: https://www.debian.org/mirror/list
	var_dump(curl_exec($ch) !== false);
	var_dump(in_array('README.*', $seen_patterns));
	var_dump(in_array('README.html', $seen_fnames));
	?>
	--EXPECT--
	bool(true)

We probably do not want changing content to affect tests.

[Sjord]

I agree that this is a little bit brittle, but this is to test that the return value of fnmatch_function works. I.e. fnmatch_function returns that only README.mirrors.txt matches and no other files, so here we expect only the contents of README.mirrors.txt.