ext/date: Change return type to static - #23317
Open
arshidkv12 wants to merge 2 commits into
Open
Conversation
ext/date: Fix DateTime return types for subclasses
arshidkv12
force-pushed
the
date-static
branch
from
August 16, 2026 13:37
8b1d131 to
6f487b3
Compare
arshidkv12
changed the title
kocsismate
reviewed
Aug 25, 2026
| * @tentative-return-type | ||
| */ | ||
| public static function createFromDateString(string $datetime): DateInterval {} | ||
| public static function createFromDateString(string $datetime): static {} |
Member
There was a problem hiding this comment.
this one is not completely right currently: always a DateInterval is returned, not the class which was invoked.
kocsismate
reviewed
Aug 25, 2026
Member
There was a problem hiding this comment.
I agree with the changes. There's a new date api in the works, but these classes will be with us for quite a lot of time, so I think it makes sense to improve them, especially because most of them are only tentative types.
There's a few declared types which are demoted to tentative types: at first, I was worried about them that they broke BC... But then I realized that static can substitute the original class, so I think it's a good solution.
LGTM, but I'm not approving the PR, let's wait for @derickr's review. And @TimWolla may also have opinion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use static return types for DateTime and related methods that preserve the called class.