Defer SAVE_OPLINE() on the INSTANCEOF fast path - #23304
Closed
staabm wants to merge 1 commit into
Closed
Conversation
The object paths (inline cache and instanceof walk) run no user code and cannot throw; only releasing a TMP operand (destructor), fetching a late-bound class (op2 UNUSED) and the undefined-variable warning need the opline saved, and now save it explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disclaimer: this change was generated by claude opus. I have little experience with php-src development
The object paths (inline cache and instanceof walk) run no user code and cannot throw; only releasing a TMP operand (destructor), fetching a late-bound class (op2 UNUSED) and the undefined-variable warning need the opline saved, and now save it explicitly.
after PR
before PR
using instanceof_fast_path_repro.php