Skip to content

Fix for PHP 8.6.0beta2 #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remicollet wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for PHP 8.6.0beta2 #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1d1596
PHP 8.6 compatibility: Replace zval_is_true
rainerjung Jul 5, 2026
6290af0
use zval_ptr_dtor_nogc instead of zval_dtor alias
remicollet Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ssh2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ LIBSSH2_MACERROR_FUNC(php_ssh2_macerror_cb)
if (FAILURE == call_user_function(NULL, NULL, data->macerror_cb, &zretval, 1, args)) {
php_error_docref(NULL, E_WARNING, "Failure calling macerror callback");
} else {
retval = zval_is_true(&zretval) ? 0 : -1;
retval = zend_is_true(&zretval) ? 0 : -1;
}
if (Z_TYPE_P(&zretval) != IS_UNDEF) {
zval_ptr_dtor(&zretval);
Expand Down
4 changes: 2 additions & 2 deletions ssh2_fopen_wrappers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ static php_stream *php_ssh2_shell_open(LIBSSH2_SESSION *session, zend_resource *
if (libssh2_channel_setenv_ex(channel, key->val, key->len, Z_STRVAL(copyval), Z_STRLEN(copyval))) {
php_error_docref(NULL, E_WARNING, "Failed setting %s=%s on remote end", ZSTR_VAL(key), Z_STRVAL(copyval));
}
zval_dtor(&copyval);
zval_ptr_dtor_nogc(&copyval);
}
} else {
php_error_docref(NULL, E_NOTICE, "Skipping numeric index in environment array");
Expand Down Expand Up @@ -831,7 +831,7 @@ static php_stream *php_ssh2_exec_command(LIBSSH2_SESSION *session, zend_resource
if (libssh2_channel_setenv_ex(channel, key->val, key->len, Z_STRVAL(copyval), Z_STRLEN(copyval))) {
php_error_docref(NULL, E_WARNING, "Failed setting %s=%s on remote end", ZSTR_VAL(key), Z_STRVAL(copyval));
}
zval_dtor(&copyval);
zval_ptr_dtor_nogc(&copyval);
}
} else {
php_error_docref(NULL, E_NOTICE, "Skipping numeric index in environment array");
Expand Down
Loading