fix(pool): extended pipeline mixed messages for multi-shard - #1364
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
The unit tests and go test should showcase the issue better. The issue appears on multi-shard configuration for requests that try to aggregate things (pgdog/src/backend/pool/connection/multi_shard/mod.rs). I have doubts about quality of the fix and the code overall in multi_shard and I believe there are other possible issues with it (like ErrorResponse handling, portals handling, anonymous commands), but I hope to fix some of the problems rn and maybe revisit and overhaul the whole flow completely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issues with multi-shard messages aggregation when multiple parse/describes commands sent in the pipeline.