Skip to content

fix(pool): extended pipeline mixed messages for multi-shard - #1364

Merged
meskill merged 2 commits into
mainfrom
meskill-2026-08-14-the-lol
Aug 14, 2026
Merged

fix(pool): extended pipeline mixed messages for multi-shard#1364
meskill merged 2 commits into
mainfrom
meskill-2026-08-14-the-lol

Conversation

@meskill

@meskill meskill commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Fix the issues with multi-shard messages aggregation when multiple parse/describes commands sent in the pipeline.

  • proper handle for RowDescription counter to reset state and forward it to the client
  • reorganize saving of RowDescription in state to pick the proper RD for validation and decoder
  • make sure the decoder gets proper RowDescription and Bind codes when processing the response rows

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.64974% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pgdog/src/backend/pool/connection/aggregate.rs 80.00% 1 Missing ⚠️
...end/client/query_engine/test/pipeline_execution.rs 99.74% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@meskill

meskill commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

The unit tests and go test should showcase the issue better. The issue appears on multi-shard configuration for requests that try to aggregate things (pgdog/src/backend/pool/connection/multi_shard/mod.rs).

I have doubts about quality of the fix and the code overall in multi_shard and I believe there are other possible issues with it (like ErrorResponse handling, portals handling, anonymous commands), but I hope to fix some of the problems rn and maybe revisit and overhaul the whole flow completely.

@levkk levkk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice find

@meskill
meskill merged commit 23edcaf into main Aug 14, 2026
29 checks passed
@meskill
meskill deleted the meskill-2026-08-14-the-lol branch August 14, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants