Remove uneccessary AST copy - #1357
Merged
Merged
Conversation
We were previously parsing an AST only to immediatley copy it onto a new memory arena and throw the original away. I've added a function on the parser side to allow us to skip this step. We can start using it now
levkk
approved these changes
Aug 13, 2026
levkk
left a comment
levkk
left a comment
Collaborator
There was a problem hiding this comment.
Oh neat! This might even register on a benchmark
Contributor
Author
|
It's probably pretty minor, but yeah cutting ~50% of the allocations should be a visible change |
Collaborator
|
The trick is testing it with a big query: 
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Collaborator
|
I'm going to merge this optimization to include it in today's release. Let me know if there is anything else needed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously parsing an AST only to immediatley copy it onto a new memory arena and throw the original away. I've added a function on the parser side to allow us to skip this step. We can start using it now