Run against Postgres regression tests, add memory leak test and fix some DDL - #46
Conversation
levkk
changed the title
|
@sgrif gonna merge this one, seems solid, ping me if you need any changes here |
| .allowlist_item("pg_query_split_with_scanner") | ||
| .allowlist_item("pg_query_free_split_result") | ||
| .allowlist_item("wrapped_raw_expression_tree_walker_impl") | ||
| .override_abi( |
There was a problem hiding this comment.
What's the reasoning for removing this? This will result in panics turning into process aborts
There was a problem hiding this comment.
Oh oops! Not sure, let me double check. Would of been good to have a test to catch this one.
There was a problem hiding this comment.
Yeah, surprised they didn't. I remember having explicit tests for this
There was a problem hiding this comment.
Ah, it's because we have the catch_unwind in a different spot now. So this change shouldn't break anything, but still seems unrelated to everything else in the PR
There was a problem hiding this comment.
Oh I see what happened. It wasn't linking on Mac (but links on Linux). Not sure why though.
2 participants
parseanddeparseagainst the Postgres regression tests suiteGRANTandCREATE STATISTICShandlingTIL:
pg_queryruns itself against Postgres regression tests; we do that now too