Repository navigation
feat: add mvtbtool --test smoke test, fix silent Open3D banner skip - #62
Merged
Merged
Conversation
Mirrors rtbtool's --test flag (see RTB's feat/rtbtool-smoke-test): a non-interactive check that prints package versions and exercises one real numeric code path per package (Image.smooth for OpenCV, PointCloud.voxel_grid for Open3D), exiting 0/1 instead of dropping into IPython. Also fixes make_banner() silently omitting Open3D from the version line when it's not installed -- now shows "Open3D==not installed" instead, in both the banner and --test output. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 2 high |
🟢 Metrics 12 complexity · 0 duplication
Metric Results Complexity 12 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--testflag tomvtbtool, mirroring RTB's--testflag onrtbtool(same shape, same rationale): a non-interactive environment smoke test that prints package versions, exercises one real numeric code path per package (Image.smooth()for OpenCV,PointCloud.voxel_grid()for Open3D), and exits 0/1 instead of dropping into an interactive IPython shell. Not a substitute for the pytest suite — a fast "did this environment come together correctly" check.make_banner()silently omitting Open3D from the version line when it isn't installed — now printsOpen3D==not installedexplicitly, in both the banner and--testoutput, instead of just leaving it out.Test plan
--testverified in an env without Open3D: OpenCV check passes, Open3D check reportsFAILwith a clear reason, exit code 1--testverified in an env with Open3D 0.19.0 installed: both checks pass, exit code 0tests/test_bin.py::TestMvtbtool::test_smoke_testcovers both cases, gated on local Open3D availability