Repository navigation
ci: pin conda opencv install to <5 to match pyproject.toml - #26
Merged
Merged
Conversation
ci.yml's micromamba create-args installed the bare `opencv` conda-forge package with no version constraint. conda-forge recently published opencv 5.0.0, so CI silently started testing against opencv5 while pyproject.toml still pins opencv-python/opencv-contrib-python to <5.0.0 (the opencv5 migration isn't finished yet, on a separate branch). Result: CI now fails across the whole test matrix on opencv4->5 API changes (cv2.BRISK_create, cv2.aruco.estimatePoseSingleMarkers, MSER indexing shape) that are unrelated to whatever a given PR actually changes. Pin both `opencv` occurrences (test and codecov jobs) to opencv<5 to match the existing pip-level constraint until the opencv5 migration branch is ready to move both pins together.
Up to standards ✅🟢 Issues
|
Every sibling toolbox (robotics-toolbox-python, bdsim, spatialmath-python) uses plain actions/setup-python + pip install .[dev] for CI. machinevision-toolbox-python's ci.yml is the only one using mamba-org/setup-micromamba with a hand-maintained create-args package list -- an outlier, not a deliberate requirement (nothing in this package's dependencies actually needs conda). Directly connected to the opencv5 pin fix in this same PR: ci.yml installs everything via create-args and then runs `pip install .[dev] --no-deps`, so pyproject.toml's own version pins never reach pip's resolver at all. That's how CI silently drifted onto conda-forge's opencv 5.0.0 despite pyproject.toml pinning <5.0.0.
petercorke
added a commit
that referenced
this pull request
Jul 29, 2026
Pull in #26's ci.yml fix so this PR's own workflow file (loaded from this branch's head, not main, for pull_request-triggered runs) actually tests against opencv4 instead of the unpinned conda-forge opencv5 drift.
petercorke
added a commit
that referenced
this pull request
Jul 29, 2026
Pull in #26's ci.yml fix so this PR's own workflow file (loaded from this branch's head, not main, for pull_request-triggered runs) actually tests against opencv4 instead of the unpinned conda-forge opencv5 drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ci.yml's conda/micromamba install used the bareopencvconda-forge package with no version constraint. conda-forge has since published opencv 5.0.0, so CI silently started testing against opencv5 whilepyproject.tomlstill pinsopencv-python<5.0.0/opencv-contrib-python<5.0.0— the opencv5 migration isn't finished yet (separate, in-progress branch).cv2.BRISK_createmoved,cv2.aruco.estimatePoseSingleMarkersremoved/renamed, MSER indexing return shape changed.opencvoccurrences (testandcodecovjobs) toopencv<5, matching the existing pip-level constraint.tech-debt.mdso the pin isn't casually removed before the migration branch is actually ready.Test plan
create-argsblock parses correctly andopencv<5becomes its own token (not shell-interpreted —setup-micromambapassescreate-argsdirectly as CLI args, not through a shell)