feat: HashOp_BLAKE3 in Go doHash + Blake3IavlSpec - #6
Open
hard-nett wants to merge 6 commits into
Open
Conversation
Close the Go/Rust gap: proto enum 9 was already in rust do_hash and the HashOp table, but Go doHash rejected it. Wire zeebo/blake3 Sum256, treat Blake3IavlSpec as IAVL-like for prefix checks (SHA-256 or BLAKE3), export rust blake3_iavl_spec, add the food vector, and BenchmarkDoHash for sha256/blake2s/blake3 at 32/64/75/256 B.
Add 32-byte BLAKE2b as a native ICS-23 hash op for state trees that already use blake2b-256. Go doHash via x/crypto/blake2b.New256, Rust host blake2b_256, IAVL-like prefix checks, food vector, and BenchmarkDoHash coverage.
Member
Author
|
Also on this PR: HashOp_BLAKE2B_256 (enum 10), Blake2b256IavlSpec, food vector, BenchmarkDoHash blake2b256. Closes the 32-byte BLAKE2b gap (512-bit was already in the enum). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Go
doHashnow implements protoHashOp_BLAKE3(9) withzeebo/blake3Sum256, matching the existing Rustfoodvector. AddsBlake3IavlSpec/blake3_iavl_spec()and IAVL-like prefix checks for SHA-256 or BLAKE3. DefaultIavlSpecis unchanged.go test ./...pass.BenchmarkDoHashcovers sha256 / blake2s / blake3 at 32 / 64 / 75 / 256 B (75 B ≈ IAVL inner preimage).Interop path: ics23 (this PR) → ibc-go
proof_specscan carry Blake3 IAVL → 07-tendermint client create/migrate. Related IAVL hasher work: permissionlessweb/iavl#1 / #2.