Skip to content

K8SPG-908: use official postgis images#1455

Draft
pooknull wants to merge 3 commits intomainfrom
K8SPG-908
Draft

K8SPG-908: use official postgis images#1455
pooknull wants to merge 3 commits intomainfrom
K8SPG-908

Conversation

@pooknull
Copy link
Contributor

@pooknull pooknull commented Feb 18, 2026

https://perconadev.atlassian.net/browse/K8SPG-908

DESCRIPTION

This PR replaces perconalab/percona-postgresql-operator:main-ppgXX-postgres images with perconalab/percona-distribution-postgresql-with-postgis

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

Copilot AI review requested due to automatic review settings February 18, 2026 11:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates example manifests and E2E image/version inputs to use the percona-distribution-postgresql-with-postgis image (instead of operator-built PostGIS variants), aligning PostGIS usage with the distribution image approach.

Changes:

  • Switch PostGIS image references in sample CRs and upgrade manifest to percona-distribution-postgresql-with-postgis.
  • Update e2e-tests/release_versions to use distribution PostGIS images for PG 17/18.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
percona/controller/testdata/sidecar-resources-cr.yaml Updates test CR to use distribution PostGIS image for PG17.
e2e-tests/release_versions Updates PostGIS image tags used by E2E runs (PG17/PG18).
deploy/upgrade.yaml Updates upgrade example to use distribution PostGIS image as the target PG image.
deploy/cr.yaml Updates example CR to use distribution PostGIS image for PG17.

@egegunes egegunes added this to the v2.9.0 milestone Feb 19, 2026
@pooknull pooknull marked this pull request as ready for review February 24, 2026 10:33
Copilot AI review requested due to automatic review settings February 24, 2026 10:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (2)

percona/controller/testdata/sidecar-resources-cr.yaml:9

    1. Problem: There are two spaces after image: (image: docker.io/...), which is inconsistent formatting compared to other YAML examples in the repo.
  1. Why it matters: While YAML parsing will usually tolerate this, testdata files are often copy-pasted and diffed; inconsistent whitespace can create noisy diffs and make reviews harder.
  2. Fix: Reduce to a single space after the colon (image: docker.io/...).
  image:  docker.io/perconalab/percona-distribution-postgresql-with-postgis:17

e2e-tests/release_versions:11

    1. Problem: IMAGE_POSTGIS17 is pinned to :17.7 while the matching IMAGE_POSTGRESQL17 uses :17.7-2, and IMAGE_POSTGIS18 follows the same x.y-z build suffix pattern.
  1. Why it matters: This can make release E2E runs pull a different (or non-existent) PostGIS image build than the intended PostgreSQL 17 build, leading to inconsistent or failing test runs.
  2. Fix: Align the PostGIS 17 tag format with the corresponding PostgreSQL 17 image (e.g., use the same 17.7-2 build suffix if that is the intended release).
IMAGE_POSTGIS17=percona/percona-distribution-postgresql-with-postgis:17.7

@JNKPercona
Copy link
Collaborator

Test Name Result Time
backup-enable-disable passed 00:06:44
builtin-extensions passed 00:05:18
cert-manager-tls passed 00:05:00
custom-envs passed 00:18:15
custom-extensions passed 00:13:13
custom-tls passed 00:06:17
database-init-sql passed 00:02:09
demand-backup passed 00:22:24
demand-backup-offline-snapshot passed 00:13:23
dynamic-configuration passed 00:03:06
finalizers passed 00:03:38
init-deploy passed 00:02:51
huge-pages passed 00:02:54
monitoring passed 00:06:32
monitoring-pmm3 passed 00:07:59
one-pod passed 00:05:49
operator-self-healing passed 00:09:53
pitr passed 00:11:23
scaling passed 00:04:37
scheduled-backup passed 00:25:22
self-healing passed 00:08:50
sidecars passed 00:02:49
standby-pgbackrest passed 00:11:30
standby-streaming passed 00:09:01
start-from-backup passed 00:10:49
tablespaces passed 00:06:31
telemetry-transfer passed 00:04:28
upgrade-consistency passed 00:07:18
upgrade-minor passed 00:05:51
users passed 00:04:44
Summary Value
Tests Run 30/30
Job Duration 01:45:07
Total Test Time 04:08:54

commit: 787d28a
image: perconalab/percona-postgresql-operator:PR-1455-787d28abf

fromPostgresVersion: 16
toPostgresVersion: 17
toPostgresImage: docker.io/perconalab/percona-postgresql-operator:main-ppg17-postgres
toPostgresImage: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert this

@hors hors marked this pull request as draft February 25, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants