Conversation
There was a problem hiding this comment.
Pull request overview
Updates example manifests and E2E image/version inputs to use the percona-distribution-postgresql-with-postgis image (instead of operator-built PostGIS variants), aligning PostGIS usage with the distribution image approach.
Changes:
- Switch PostGIS image references in sample CRs and upgrade manifest to
percona-distribution-postgresql-with-postgis. - Update
e2e-tests/release_versionsto use distribution PostGIS images for PG 17/18.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| percona/controller/testdata/sidecar-resources-cr.yaml | Updates test CR to use distribution PostGIS image for PG17. |
| e2e-tests/release_versions | Updates PostGIS image tags used by E2E runs (PG17/PG18). |
| deploy/upgrade.yaml | Updates upgrade example to use distribution PostGIS image as the target PG image. |
| deploy/cr.yaml | Updates example CR to use distribution PostGIS image for PG17. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
percona/controller/testdata/sidecar-resources-cr.yaml:9
-
- Problem: There are two spaces after
image:(image: docker.io/...), which is inconsistent formatting compared to other YAML examples in the repo.
- Problem: There are two spaces after
- Why it matters: While YAML parsing will usually tolerate this, testdata files are often copy-pasted and diffed; inconsistent whitespace can create noisy diffs and make reviews harder.
- Fix: Reduce to a single space after the colon (
image: docker.io/...).
image: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17
e2e-tests/release_versions:11
-
- Problem:
IMAGE_POSTGIS17is pinned to:17.7while the matchingIMAGE_POSTGRESQL17uses:17.7-2, andIMAGE_POSTGIS18follows the samex.y-zbuild suffix pattern.
- Problem:
- Why it matters: This can make release E2E runs pull a different (or non-existent) PostGIS image build than the intended PostgreSQL 17 build, leading to inconsistent or failing test runs.
- Fix: Align the PostGIS 17 tag format with the corresponding PostgreSQL 17 image (e.g., use the same
17.7-2build suffix if that is the intended release).
IMAGE_POSTGIS17=percona/percona-distribution-postgresql-with-postgis:17.7
Collaborator
commit: 787d28a |
egegunes
requested changes
Feb 25, 2026
| fromPostgresVersion: 16 | ||
| toPostgresVersion: 17 | ||
| toPostgresImage: docker.io/perconalab/percona-postgresql-operator:main-ppg17-postgres | ||
| toPostgresImage: docker.io/perconalab/percona-distribution-postgresql-with-postgis:17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPG-908
DESCRIPTION
This PR replaces
perconalab/percona-postgresql-operator:main-ppgXX-postgresimages withperconalab/percona-distribution-postgresql-with-postgisCHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
Config/Logging/Testability