chore: 专家评审收尾 — evals 补齐硬边界角色 (#4) + ADR-004 定稿 (#5)#7
Merged
Conversation
QualityExpert finding #5：evals 仅 5/19 角色，最易漂的 review-only/test-only/ deploy-only 硬边界角色全裸奔——边界违反后果最重却无回归网。 - 新增 6 份：miniapp-code-reviewer / apple-code-reviewer（review-only） + miniapp-qa-engineer / apple-qa-engineer（test-only） + deploy-engineer / apple-release-engineer（deploy-only），各 3-4 条 - 用例锁各自硬边界：禁改源码 / 不自跑只 audit / 拒静态 pass / 二元 gate / Pool=1 禁 fan-out / 密钥不进客户端 - 8 个硬边界角色（3 reviewer + 3 qa + 2 deploy/release）现已全覆盖 - evals/README.md Coverage scope 更新为 11/19 + 硬边界全覆盖理由（驳原"miniapp mirror web 即低风险"——边界违反成本与轨道无关） - bash evals/run.sh validate：11/11 通过 Closes #4。
…s.json 漂移） ArchExpert finding #3：ADR-004 是唯一非 Accepted 的 ADR，正文提议 auto 却与 settings.json 已落的 tmux 公开打架（SSOT 漂移），retro 死线 2026-06-24。 2026-06-09 初版据 issue #24292 选 auto（纯 iTerm2 下 tmux 回退 in-process）； 但 2026-06-11 本机实测（CC v2.1.170）+ 2026-06-17 本会话复证：纯 iTerm2 下 tmux 成功 spawn 原生分屏（backendType:"iterm2"），#24292/#23815 均已关（CHANGELOG v2.1.77）。 按 ADR 自身回填规则「实测通过→收敛」，决策翻转为 tmux。 - 状态 Proposed → Accepted；决策/备选/影响/后续工作/版本查证全部对齐 tmux - settings.json 维持 tmux（定稿追认现值，无需改配置，漂移消除） - FIRST_RUN.md split-pane 表述对齐（iTerm2 直接 claude 即原生分屏，非"唯一靠 tmux"） Closes #5。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
专家评审最后两项,各 close 一个 issue。
QE#5 — evals 覆盖 5→11/19（Closes #4）
最易漂的 review-only/test-only/deploy-only 硬边界角色此前无回归网。
miniapp-code-reviewer/apple-code-reviewer（review-only）+miniapp-qa-engineer/apple-qa-engineer（test-only）+deploy-engineer/apple-release-engineer（deploy-only）,各 3-4 条evals/README.mdCoverage scope 更新为 11/19，并驳原"miniapp mirror web 即低风险"理由bash evals/run.sh validate→ 11/11 通过Arch#3 — ADR-004 定稿 tmux（Closes #5）
唯一非 Accepted 的 ADR，正文提议 auto 与 settings.json 的 tmux 公开打架（SSOT 漂移，retro 死线 06-24）。
backendType:"iterm2"原生分屏,#24292/#23815 已关）settings.json维持 tmux（追认现值,无需改配置,漂移消除）;FIRST_RUN.mdsplit-pane 表述对齐验证
✅ eval validate 11/11;✅ 全量 lint 通过、roles 无 drift