This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merge 2.0.1 backport branch into mainline master - #7842
Merged
Conversation
To not change spec version, see #7686 (comment)
See rust-lang/rust#73996 Backports: #7764 #7656
Xanewok
force-pushed
the
igor-v2-backports-forwardmerge
branch
from
January 6, 2021 18:27
1974065 to
19610f9
Compare
Xanewok
requested review from
NikVolf,
andresilva,
athei and
kianenigma
as code owners
January 6, 2021 18:27
Contributor
Author
gnunicorn
approved these changes
Jan 6, 2021
Contributor
Author
|
I'm somewhat torn on B-* labels - at the same time it's not really important in terms of API changes, runtime etc. but these definitely should be documented as a patch release. Leaving as B0-silent for now. @gnunicorn Polkadot CI check is green now (thanks @bkchr) and everything seems to be good to go. Should we merge this? |
gnunicorn
added
the
C1-low
Contributor
Author
|
We should probably backport #7838 as well. Will do that tomorrow. |
bkchr
approved these changes
Jan 6, 2021
This is done because at the time of writing cargo-unleash does not fully support partial workspace publishing and mixes both local and crates.io versions of the packages, leading to errors in the release check workflow.
Xanewok
force-pushed
the
igor-v2-backports-forwardmerge
branch
from
January 8, 2021 18:38
19610f9 to
6887dd9
Compare
Contributor
Author
|
@gnunicorn updated with latest changes from #7686, hopefully this should be good to go once CI agrees |
Contributor
Author
|
All is green so tagging #7686 for 2.0.1 release. |
Xanewok
force-pushed
the
igor-v2-backports-forwardmerge
branch
from
January 8, 2021 19:39
6887dd9 to
e0fee22
Compare
Contributor
Author
|
Force-pushed a new merge commit that includes a new signed commit for 2.0.1 (2cd2096). |
Contributor
Author
|
Blocked on #7844. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #7686 (reviewed and accepted) but targeting master to retain future release tag in the master history line.