build(wasm): disable wasm-opt one-caller inlining - #993
Merged
Merged
Conversation
-Oz inlines every single-caller function, which shrinks the raw module by 11% but grows the brotli output by 7%: the merged bodies compress worse. With --one-caller-inline-max-function-size 0 the web core goes from 775.4 KiB to 719.5 KiB brotli (1.02 MiB to 952.5 KiB gzip), raw size unchanged.
Contributor
|
CI Status: 23 required jobs green, 19 passed and 4 skipped by path filter. All job results
Signing credentials: failure as of 2026-09-25, a release may fail Commit |
Contributor
iOS simulator previewBuilt from gh run download 36120132491 --name simulator-preview-523e80d21
unzip polkadot-app-*.app.zip
xcrun simctl install booted polkadot-app.app
xcrun simctl launch booted io.parity.polkadotapp.developOr download it in a browser, which arrives as a zip wrapping An arm64 simulator slice, so it needs an Apple Silicon Mac and does not |
pgherveou
approved these changes
Sep 25, 2026
14 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core and verifiable WASM builds run wasm-opt with
-Oz --one-caller-inline-max-function-size 0.At
-O2and above, wasm-opt inlines every function that has a single caller. That makes the raw module smaller, but the merged bodies compress worse, so what actually goes over the wire grows. With that one pass turned off, the other-Ozsavings stay and the compressed output is smaller.webcoretestingcoretruapi_verifiable