ci: retire the smoke test and correct what the announcements left stale - #943
Merged
Merged
Conversation
The smoke test proved the notification path once. Keeping it leaves a button that puts a message in a room people read, available to anyone with write access and gated by nothing, so it goes now that it has answered its question. The publishing table named two link secrets that nothing reads and omitted the room list that everything does, and every workflow it pointed at carried a filename from before the workflows moved to the repository root. The names it gives now all resolve. Two comments described a nightly that builds Safetynet. It does not: that leg is held and Safetynet ships from the app repository, which makes the on-demand workflow the only one here that builds it, and leaves auto-merge waiting on one leg rather than two.
github-actions
Bot
added
github_actions
Contributor
|
CI Status: 23 required jobs green, 15 passed and 8 skipped by path filter. All job results
Signing credentials: null as of null, a release may fail Commit |
Contributor
iOS simulator previewBuilt from gh run download 35915932457 --name simulator-preview-35e40cac5
unzip polkadot-app-*.app.zip
xcrun simctl install booted polkadot-app.app
xcrun simctl launch booted io.parity.polkadotapp.developOr download it in a browser, which arrives as a zip wrapping An arm64 simulator slice, so it needs an Apple Silicon Mac and does not |
valentinfernandez1
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke test proved the notification path once, on the run that announced into the room. Keeping it leaves a button that puts a message in front of people, available to anyone with write access and gated by nothing, so it goes now that it has answered its question. It stays in history if the path ever needs proving again.
The publishing table named two link secrets that nothing reads, omitted the room list that everything does, and pointed at four workflow filenames from before the workflows moved to the repository root. Every name it gives now resolves.
Two comments described a nightly that builds Safetynet. It does not, so the on-demand workflow is the only one here that builds it, and auto-merge waits on one leg rather than two.
Not addressed here, and worth a decision rather than a tidy-up:
TESTFLIGHT_DISTRIBUTION_LINKis read by both the nightly and the release announcement, but the nightly distributes to an external group and the release does not. A join link is per-group per-app, so at most one of the two is pointing testers at the right place.