chore(hosts): refresh the iOS import from the app repository - #909
Merged
Merged
Conversation
github-actions
Bot
added
the
host-work
Contributor
|
CI Status: 23 required jobs green, 14 passed and 9 skipped by path filter. All job results
Signing credentials: null as of null, a release may fail Commit |
Contributor
iOS simulator previewBuilt from gh run download 35912045582 --name simulator-preview-4b56ff6dd
unzip polkadot-app-*.app.zip
xcrun simctl install booted polkadot-app.app
xcrun simctl launch booted io.parity.polkadotapp.developOr download it in a browser, which arrives as a zip wrapping An arm64 simulator slice, so it needs an Apple Silicon Mac and does not |
pgherveou
approved these changes
Sep 22, 2026
Takes the source tree at e714ac4, 76 commits on from the recorded import, and replays this repository's adaptations on top. The three that matter survived: the app dependencies still resolve the core from the tree rather than a released binary, the vendored workflows stay deleted now that they are re-homed at the root, and the TrUAPI confirmation and issue-report modules that exist only here are still present. One conflict, over the Firebase remote-config keys, where upstream added one alongside the two this repository carries. Both are kept.
Upstream moved on from the previous import while this was open. The adaptations replayed without conflict this time: the app dependencies still resolve the core from the tree, the vendored workflows stay deleted, the modules that exist only here are present, and the Firebase remote-config keys resolved by hand last time survived.
TarikGul
force-pushed
the
tg/refresh-ios-0922
branch
from
September 23, 2026 13:00
e436ae2 to
a283b10
Compare
The refresh brought a ninth requirement on ProductHostProviding, and the protocol carries no default for it, so a hand written conformer in the tests stopped compiling and took the whole target with it. The failure reads as the suite failing rather than as a type missing a method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes the source tree at
e714ac4, 76 commits on from the recorded import.The adaptations survived the replay: the app dependencies still resolve the core from the tree rather than a released binary, the vendored workflows stay deleted now that they are re-homed at the root, and the TrUAPI confirmation and issue-report modules that exist only here are still present.
One conflict, in the Firebase remote-config keys, where upstream added
payment_asset_configalongside the two this repository carries for issue reporting. Both are kept.Part of #669.