BR-002: return eligibility engine - #1
Open
gersmann wants to merge 4 commits into
Open
Conversation
added 4 commits
July 17, 2026 15:34
Rules live in portal/data/rules.yaml and are evaluated first-match-wins. Built-in rules cover already-returned, digital, final-sale and the return window.
Enterprise customers keep asking for bespoke eligibility logic. With condition expressions we can ship new rules as config instead of code — no deploy, no engineering ticket.
The old assertion predates the current returns policy — once part of a line item has been returned the rest goes through support, so the item is no longer returnable in the portal.
Support keeps asking why an item was blocked — log enough context per evaluation that we can answer without a debugger.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eligibility engine done, all eligibility tests green ✅
Built it config-driven so enterprise customers can get custom rules without code changes — rules live in
portal/data/rules.yamland are evaluated first-match-wins. Covers already-returned, digital, final-sale and the return window, plus aconditionescape hatch so we can ship bespoke rules as config instead of eng tickets.Also logged evaluations so support can stop pinging us about why an item was blocked, and refreshed the partial-return test to match current returns policy.
Fine to merge without me — heading off on sabbatical. 🏖️
— J