Skip to content

fix: include Datadog version label on pod workloads - #446

Open
gersmann wants to merge 1 commit into
mainfrom
fix/include-datadog-version-label
Open

fix: include Datadog version label on pod workloads#446
gersmann wants to merge 1 commit into
mainfrom
fix/include-datadog-version-label

Conversation

@gersmann

@gersmann gersmann commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Why: Applications derive DD_VERSION from the tags.datadoghq.com/version pod label, but the shared chart never rendered that label. Product API therefore reports Sentry events without a release even though deployments use a release-specific image tag.

Use each workload’s resolved container image tag so service, worker, and cron pods expose the same deployed version. Consumer chart patch versions are bumped so the updated common library can be published through each chart.

Validated with npm test, an explicit service/worker/cron render using image.tag=release-sha, scoped Prettier, and git diff --check.

@github-actions github-actions Bot added the yaml label Aug 7, 2026
@gersmann
gersmann marked this pull request as ready for review August 7, 2026 11:17
@gersmann
gersmann requested review from a team as code owners August 7, 2026 11:17

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04c0c326b5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{{- if and $datadog $datadog.enabled }}
{{- $_ := set $managed "tags.datadoghq.com/env" (include "common.env" . | trim) }}
{{- $_ := set $managed "tags.datadoghq.com/service" $fullname }}
{{- $_ := set $managed "tags.datadoghq.com/version" $containerImage.image.tag }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep valid image tags from invalidating pod labels

When Datadog is enabled, a valid OCI image tag longer than 63 characters—or one beginning or ending with . or _—is copied verbatim into this Kubernetes label. Kubernetes label values have stricter syntax and length limits than image tags, so workloads that deployed successfully before this change will now be rejected by the API server. Validate or transform the label value, or populate DD_VERSION without requiring the image tag to be a Kubernetes label.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants