Add a default module mapping for testcontainers-opensearch - #23675
Open
jasonwbarnett wants to merge 1 commit into
Open
jasonwbarnett wants to merge 1 commit into
jasonwbarnett wants to merge 1 commit into
Conversation
tdyas
approved these changes
Sep 19, 2026
Contributor
|
Approved. Please resolve merge conflict with |
The distribution provides `testcontainers.opensearch`. Neither the existing pattern rules nor the hyphen-to-underscore fallback produce a dotted module name, so the entry has to be explicit. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016zQB3cnDn6qtYrZaub8Bj9
jasonwbarnett
force-pushed
the
add-testcontainers-opensearch-module-mapping
branch
from
September 20, 2026 12:56
975c18b to
494543d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testcontainers-opensearchprovidestestcontainers.opensearch. Nothing in the defaults produces that today: no pattern rule inDEFAULT_MODULE_PATTERN_MAPPINGmatchestestcontainers-*, and the dist-name fallback inmodule_mapper.pyonly replaces hyphens with underscores, so the import currently resolves totestcontainers_opensearch.Verified against the published wheel's file list rather than inferred from the distribution name: it ships
testcontainers/opensearch/__init__.py, plus a stray top-leveltestspackage that this entry deliberately does not claim. No other entry claimstestcontainers.opensearch, so this adds no ambiguity.LLM assistance notice
This PR was written primarily by Claude Code (Claude Opus 5): the wheel verification, the diff, the release note, and this description. I directed the scope and reviewed the result.