Skip to content

added docs for installing p4sim#706

Merged
jafingerhut merged 2 commits intop4lang:masterfrom
Vineet1101:p4sim-exercises
Feb 2, 2026
Merged

added docs for installing p4sim#706
jafingerhut merged 2 commits intop4lang:masterfrom
Vineet1101:p4sim-exercises

Conversation

@Vineet1101
Copy link
Contributor

This PR add documents and some example on using P4Sim( a P4 based ns-3 module used to run P4 switches inside ns-3 environment)

@Vineet1101
Copy link
Contributor Author

@fruffy @jafingerhut can you tell where should I add the docs and examples of using p4sim

@fruffy
Copy link
Contributor

fruffy commented Dec 10, 2025

@fruffy @jafingerhut can you tell where should I add the docs and examples of using p4sim

We have a doc folder. I would consider placing it there, then hinting on the top-level readme.

Copy link
Contributor

@fruffy fruffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to sign the DCO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know LLMs generally use emojis a lot but I would consider dropping them. They're often just clutter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have copy pasted the documentation from the original P4Sim docs will remove the emojis

Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
@Vineet1101
Copy link
Contributor Author

hey @fruffy @jafingerhut can you please review it

@fruffy
Copy link
Contributor

fruffy commented Dec 20, 2025

hey @fruffy @jafingerhut can you please review it

It looks good from my side. @jafingerhut usually merges/manages PRs for this repo

@Vineet1101
Copy link
Contributor Author

hey @jafingerhut can you please review this

@Dscano
Copy link
Contributor

Dscano commented Jan 18, 2026

@fruffy, could you please add me and @Mingyumaz as reviewers?

@fruffy
Copy link
Contributor

fruffy commented Jan 18, 2026

@fruffy, could you please add me and @Mingyumaz as reviewers?

Reviewing usually requires repository write permissions, but I added you as P4 members, which was overdue anyway.

@Vineet1101
Copy link
Contributor Author

hey @Dscano can you review this please and if everything is good can you merge it

Copy link
Collaborator

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried only the part of the install instructions at the beginnins for ns3.39, and they seemed to work without error.

Note: It is confusing to beginners that the first example command to run gives an error:

$ ./ns3 run "exampleA"
Traceback (most recent call last):
  File "/home/p4/workdir/ns3.39/./ns3", line 1615, in <module>
    main()
  File "/home/p4/workdir/ns3.39/./ns3", line 1575, in main
    raise Exception("Couldn't find the specified program: %s" % target_to_run)
Exception: Couldn't find the specified program: exampleA

It would be nice if there were some working instructions for steps to try to run a first simple P4 program in the p4sim environment.

@jafingerhut jafingerhut merged commit db898bc into p4lang:master Feb 2, 2026
1 check passed
@Vineet1101
Copy link
Contributor Author

so I can add those instructions to run a program in a PR??

@jafingerhut
Copy link
Collaborator

so I can add those instructions to run a program in a PR??

If you would like to, please do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments