added docs for installing p4sim#706
Conversation
|
@fruffy @jafingerhut can you tell where should I add the docs and examples of using p4sim |
We have a doc folder. I would consider placing it there, then hinting on the top-level readme. |
doc/Using_p4sim.md
Outdated
There was a problem hiding this comment.
I know LLMs generally use emojis a lot but I would consider dropping them. They're often just clutter.
There was a problem hiding this comment.
I have copy pasted the documentation from the original P4Sim docs will remove the emojis
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
eb7ad3a to
7d3d62b
Compare
|
hey @fruffy @jafingerhut can you please review it |
It looks good from my side. @jafingerhut usually merges/manages PRs for this repo |
|
hey @jafingerhut can you please review this |
|
@fruffy, could you please add me and @Mingyumaz as reviewers? |
Reviewing usually requires repository write permissions, but I added you as P4 members, which was overdue anyway. |
|
hey @Dscano can you review this please and if everything is good can you merge it |
jafingerhut
left a comment
There was a problem hiding this comment.
I have tried only the part of the install instructions at the beginnins for ns3.39, and they seemed to work without error.
Note: It is confusing to beginners that the first example command to run gives an error:
$ ./ns3 run "exampleA"
Traceback (most recent call last):
File "/home/p4/workdir/ns3.39/./ns3", line 1615, in <module>
main()
File "/home/p4/workdir/ns3.39/./ns3", line 1575, in main
raise Exception("Couldn't find the specified program: %s" % target_to_run)
Exception: Couldn't find the specified program: exampleA
It would be nice if there were some working instructions for steps to try to run a first simple P4 program in the p4sim environment.
|
so I can add those instructions to run a program in a PR?? |
If you would like to, please do so. |
This PR add documents and some example on using P4Sim( a P4 based ns-3 module used to run P4 switches inside ns-3 environment)