rdl: make sure mem codegen accounts for entry byte width#471
Merged
Aaron-Hartwig merged 3 commits intomainfrom Feb 27, 2026
Merged
rdl: make sure mem codegen accounts for entry byte width#471Aaron-Hartwig merged 3 commits intomainfrom
Aaron-Hartwig merged 3 commits intomainfrom
Conversation
Collaborator
Author
|
Testing this now. |
Collaborator
Author
|
This appears to be working. |
Collaborator
Author
|
The first bug covered up a second one (fixed by 8547e19): we were trimming the address before doing the bytes-to-entry conversion (divide by 4), leading us to lose the upper two bits in the event we were attempting to address anything in the 1024-4095 range. Prior to this we were just wrapping around in the 0-1023 space. |
nathanaelhuffman
approved these changes
Feb 27, 2026
Collaborator
nathanaelhuffman
left a comment
nathanaelhuffman
left a comment
There was a problem hiding this comment.
lgtm, one note about how I think the addr construction can be simplified with 1 fewer resize.
Collaborator
Author
|
Simulation is blocked by an nvc regression: nickg/nvc#1438. |
Collaborator
Author
I rolled back our CI environment from nvc-1.19.1 to nvc-1.18.2 as this seems to have broken in nvc-1.19.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #470