AB#115039 Disable the secrets manager as we don't have any secrets in…#210
Merged
sebastianchristopher merged 2 commits intomasterfrom Mar 31, 2026
Merged
AB#115039 Disable the secrets manager as we don't have any secrets in…#210sebastianchristopher merged 2 commits intomasterfrom
sebastianchristopher merged 2 commits intomasterfrom
Conversation
… AWS when testing.
sebastianchristopher
requested review from
buckett,
Copilot,
lardo-de-arnaud and
nicholaswilson100
There was a problem hiding this comment.
Pull request overview
Adjusts Spring configuration so AWS Secrets Manager integration is disabled by default (helpful for local/test runs without AWS secrets) and only enabled when the aws profile is active, aligning key-loading behavior with the same profile boundary.
Changes:
- Disable AWS Secrets Manager by default in
application.properties. - Re-enable AWS Secrets Manager in the
awsSpring profile viaapplication-aws.properties. - Switch
KeyPairLoadingServiceimplementations to useaws/!awsprofiles (instead oflocal/!local).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/resources/application.properties |
Disables Secrets Manager by default for non-AWS runs. |
src/main/resources/application-aws.properties |
Enables Secrets Manager when the aws profile is active. |
src/main/java/uk/ac/ox/ctl/ltiauth/LocalKeyPairLoadingService.java |
Activates local key loading for all non-aws profiles. |
src/main/java/uk/ac/ox/ctl/ltiauth/AwsKeyPairLoadingService.java |
Restricts AWS Secrets Manager key loading to the aws profile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
buckett
approved these changes
Mar 30, 2026
Member
buckett
left a comment
buckett
left a comment
There was a problem hiding this comment.
Looks good, I think you can also remove the disabling of the secrets manager from the test application properties as it's in the default now.
…pplication properties as it's in the default now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… AWS when testing.