Repository navigation
Feature: Add ADR core and plugin like zones (#586) - #587
agnetemoos wants to merge 14 commits into
Conversation
| reevaluation. | ||
|
|
||
| [core-templates]: https://github.com/os2display/os2display-produktforvaltning/blob/main/dokumenter/core-templates.md | ||
|
|
There was a problem hiding this comment.
What is Core should be evident from the code instead of an external list.
This could be achieved by organizing Feeds into Core and Contrib folders:
src/Feed/Core
src/Feed/Contrib
assets/admin/components/feed-sources/templates/core/
assets/admin/components/feed-sources/templates/contrib/
Likewise with templates:
assets/shared/templates/core/
assets/shared/templates/contrib/
There was a problem hiding this comment.
I believe we should implement the division administratively before translating it into code. We can begin operating under the new split and evaluate its effectiveness after a period of time. If it proves successful, we can then develop separate code paths. The division in the code must not become a blocking issue.
In the issue tracker, it will be clear whether an issue belongs to the core or the plugin zone. And that is the crucial part, because it determines who should be billed.
There was a problem hiding this comment.
Maybe we could open an issue on aligning the code after decisions have been made.
|
Great work @agnetemoos. The developers and I have discussed this PR and the comments that tuj has left is on behalf of all of us. We believe that this PR is ready for merge - do we need to do anything on that account or will you merge it yourself? |
|
Thank you, @Anna-itk . There are some minor Markdown linting erreors that I will fix. Then I will merge. |
Link to ticket
#586
Description
Adds ADRs 012 and 013 to define the boundary between core and plugin-like zones, including contribution requirements, responsibilities, and maintenance expectations.
Checklist
If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.