Skip to content

Feature: Add ADR core and plugin like zones (#586) - #587

Open
agnetemoos wants to merge 14 commits into
release/3.0.0from
feature/issue-586-adr-core-and-plugin-like-zones
Open

agnetemoos wants to merge 14 commits into
release/3.0.0from
feature/issue-586-adr-core-and-plugin-like-zones

Conversation

@agnetemoos

Copy link
Copy Markdown
Contributor

Link to ticket

#586

Description

Adds ADRs 012 and 013 to define the boundary between core and plugin-like zones, including contribution requirements, responsibilities, and maintenance expectations.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

@agnetemoos
agnetemoos marked this pull request as draft September 30, 2026 10:39
@agnetemoos agnetemoos changed the title WIP: feature: Add ADR core and plugin like zones (#586) Feature: Add ADR core and plugin like zones (#586) Sep 30, 2026
@agnetemoos
agnetemoos marked this pull request as ready for review September 30, 2026 12:10
reevaluation.

[core-templates]: https://github.com/os2display/os2display-produktforvaltning/blob/main/dokumenter/core-templates.md

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Core should be evident from the code instead of an external list.

This could be achieved by organizing Feeds into Core and Contrib folders:
src/Feed/Core
src/Feed/Contrib
assets/admin/components/feed-sources/templates/core/
assets/admin/components/feed-sources/templates/contrib/

Likewise with templates:
assets/shared/templates/core/
assets/shared/templates/contrib/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should implement the division administratively before translating it into code. We can begin operating under the new split and evaluate its effectiveness after a period of time. If it proves successful, we can then develop separate code paths. The division in the code must not become a blocking issue.

In the issue tracker, it will be clear whether an issue belongs to the core or the plugin zone. And that is the crucial part, because it determines who should be billed.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could open an issue on aligning the code after decisions have been made.

Comment thread docs/adr/013-plugin-like-zones.md
Comment thread docs/adr/013-plugin-like-zones.md Outdated
@agnetemoos
agnetemoos requested a review from tuj October 6, 2026 13:59

@tuj tuj left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment

@Anna-itk

Copy link
Copy Markdown

Great work @agnetemoos. The developers and I have discussed this PR and the comments that tuj has left is on behalf of all of us. We believe that this PR is ready for merge - do we need to do anything on that account or will you merge it yourself?
Following the approval of this PR how things should be handled if we have features that should be maintained outside core is yet to be decided and described. We expect that this is going to be discussed at the meeting on the 23rd of november.

@agnetemoos

Copy link
Copy Markdown
Contributor Author

Thank you, @Anna-itk .

There are some minor Markdown linting erreors that I will fix. Then I will merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants