Support of unqualified-search-registries in registries.conf#434
Support of unqualified-search-registries in registries.conf#434jonesbusy merged 1 commit intooras-project:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
============================================
+ Coverage 87.59% 88.42% +0.82%
- Complexity 685 707 +22
============================================
Files 40 42 +2
Lines 2056 2117 +61
Branches 233 242 +9
============================================
+ Hits 1801 1872 +71
+ Misses 164 149 -15
- Partials 91 96 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ac9a2d to
021e544
Compare
400876b to
a738037
Compare
a65ba92 to
9325016
Compare
There was a problem hiding this comment.
Pull request overview
Implements initial parsing of containers/registries.conf (TOML) and wires it into registry/reference handling to support unqualified-search-registries, with accompanying test updates.
Changes:
- Added
TomlUtils(Jackson TOML) and tests for TOML parse/serialize. - Added
RegistriesConfloader and tests for readingunqualified-search-registriesfrom standard paths. - Updated
Registry/ContainerRefbehavior and tests around effective registry selection for unqualified references.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/land/oras/utils/TomlUtils.java | New TOML helper to read/write objects using Jackson TOML. |
| src/test/java/land/oras/utils/TomlUtilsTest.java | Adds unit tests for TOML parsing/serialization. |
| src/main/java/land/oras/auth/RegistriesConf.java | New loader/model for registries.conf (currently focused on unqualified-search-registries). |
| src/test/java/land/oras/auth/RegistriesConfTest.java | Tests reading unqualified-search-registries from $HOME/.config/.... |
| src/main/java/land/oras/Registry.java | Loads RegistriesConf and refactors calls to use resolved ContainerRef for registry-scoped operations; adds helper cloning. |
| src/main/java/land/oras/ContainerRef.java | Adds effective registry resolution using unqualified-search-registries and modifies toString() for unqualified refs. |
| src/test/java/land/oras/ContainerRefTest.java | Adds tests for effective registry resolution with/without unqualified settings. |
| src/test/java/land/oras/DockerIoITCase.java | Splits/adjusts IT cases and updates blob fetch to use effective registry. |
| src/test/java/land/oras/auth/AuthStoreTest.java | Removes a redundant test and adds class Javadoc. |
| pom.xml | Adds jackson-dataformat-toml dependency (version via imported Jackson BOM). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6e4566c to
7ab5130
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7ab5130 to
47f357f
Compare
Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
47f357f to
5e5f017
Compare
Description
Start implementation of registries.conf
Do not use any of config for now (Just log unqualified-search-registries for now)
Testing done
Submitter checklist
mvn license:update-file-header,mvn spotless:apply,pre-commit run -a,mvn clean installbefore opening the PR