Skip to content

Comments

Support of unqualified-search-registries in registries.conf#434

Merged
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/registries
Feb 12, 2026
Merged

Support of unqualified-search-registries in registries.conf#434
jonesbusy merged 1 commit intooras-project:mainfrom
jonesbusy:feature/registries

Conversation

@jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented Oct 13, 2025

Description

Start implementation of registries.conf

Do not use any of config for now (Just log unqualified-search-registries for now)

Testing done

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@codecov
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

❌ Patch coverage is 89.62963% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.42%. Comparing base (fc87fc1) to head (5e5f017).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/ContainerRef.java 74.07% 3 Missing and 4 partials ⚠️
src/main/java/land/oras/utils/TomlUtils.java 63.63% 4 Missing ⚠️
src/main/java/land/oras/auth/RegistriesConf.java 88.88% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #434      +/-   ##
============================================
+ Coverage     87.59%   88.42%   +0.82%     
- Complexity      685      707      +22     
============================================
  Files            40       42       +2     
  Lines          2056     2117      +61     
  Branches        233      242       +9     
============================================
+ Hits           1801     1872      +71     
+ Misses          164      149      -15     
- Partials         91       96       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy force-pushed the feature/registries branch 7 times, most recently from 1ac9a2d to 021e544 Compare February 12, 2026 05:33
@jonesbusy jonesbusy marked this pull request as ready for review February 12, 2026 05:37
@jonesbusy jonesbusy added enhancement New feature or request chore breaking and removed enhancement New feature or request breaking labels Feb 12, 2026
@jonesbusy jonesbusy force-pushed the feature/registries branch 2 times, most recently from 400876b to a738037 Compare February 12, 2026 06:38
@jonesbusy jonesbusy marked this pull request as draft February 12, 2026 06:46
@jonesbusy jonesbusy force-pushed the feature/registries branch 3 times, most recently from a65ba92 to 9325016 Compare February 12, 2026 10:18
@jonesbusy jonesbusy changed the title Start implementation of registries.conf Partial support of registries.conf (unqualified-search-registries) Feb 12, 2026
@jonesbusy jonesbusy added enhancement New feature or request and removed chore labels Feb 12, 2026
@jonesbusy jonesbusy requested a review from Copilot February 12, 2026 10:21
@jonesbusy jonesbusy self-assigned this Feb 12, 2026
@jonesbusy jonesbusy marked this pull request as ready for review February 12, 2026 10:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements initial parsing of containers/registries.conf (TOML) and wires it into registry/reference handling to support unqualified-search-registries, with accompanying test updates.

Changes:

  • Added TomlUtils (Jackson TOML) and tests for TOML parse/serialize.
  • Added RegistriesConf loader and tests for reading unqualified-search-registries from standard paths.
  • Updated Registry/ContainerRef behavior and tests around effective registry selection for unqualified references.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
src/main/java/land/oras/utils/TomlUtils.java New TOML helper to read/write objects using Jackson TOML.
src/test/java/land/oras/utils/TomlUtilsTest.java Adds unit tests for TOML parsing/serialization.
src/main/java/land/oras/auth/RegistriesConf.java New loader/model for registries.conf (currently focused on unqualified-search-registries).
src/test/java/land/oras/auth/RegistriesConfTest.java Tests reading unqualified-search-registries from $HOME/.config/....
src/main/java/land/oras/Registry.java Loads RegistriesConf and refactors calls to use resolved ContainerRef for registry-scoped operations; adds helper cloning.
src/main/java/land/oras/ContainerRef.java Adds effective registry resolution using unqualified-search-registries and modifies toString() for unqualified refs.
src/test/java/land/oras/ContainerRefTest.java Adds tests for effective registry resolution with/without unqualified settings.
src/test/java/land/oras/DockerIoITCase.java Splits/adjusts IT cases and updates blob fetch to use effective registry.
src/test/java/land/oras/auth/AuthStoreTest.java Removes a redundant test and adds class Javadoc.
pom.xml Adds jackson-dataformat-toml dependency (version via imported Jackson BOM).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jonesbusy jonesbusy force-pushed the feature/registries branch 3 times, most recently from 6e4566c to 7ab5130 Compare February 12, 2026 11:58
@jonesbusy jonesbusy requested a review from Copilot February 12, 2026 12:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 9 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Valentin Delaye <jonesbusy@users.noreply.github.com>
@jonesbusy jonesbusy merged commit 67fb6e0 into oras-project:main Feb 12, 2026
8 checks passed
@jonesbusy jonesbusy deleted the feature/registries branch February 12, 2026 16:50
@jonesbusy jonesbusy changed the title Partial support of registries.conf (unqualified-search-registries) Support of unqualified-search-registries in registries.conf Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant