Skip to content

test: fix flaky TriggerReconcilerOnAllEventIT.additionalEventDuringRetryOnDeleteEvent #3634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csviri merged 1 commit into from
Sep 28, 2026
Merged

test: fix flaky TriggerReconcilerOnAllEventIT.additionalEventDuringRetryOnDeleteEvent #3634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions ...aoperatorsdk/operator/baseapi/triggerallevent/eventing/TriggerReconcilerOnAllEventIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,19 +181,16 @@ void additionalEventDuringRetryOnDeleteEvent() {
extension.create(res);
extension.delete(getResource());

await()
.pollDelay(Duration.ofMillis(30))
.untilAsserted(
() -> {
assertThat(reconciler.getEventCount()).isGreaterThan(2);
});
var eventCount = reconciler.getEventCount();

// Don't assume a fixed number of reconciliations before the first retry: if the delete event
// arrives before the first reconciliation reads the resource, the finalizer-adding
// reconciliation is skipped. The reconciler increments the counter before it starts waiting,
// and nothing else reconciles while it waits, so the count read after this is stable.
await()
.untilAsserted(
() -> {
assertThat(reconciler.isWaiting()).isTrue();
});
var eventCount = reconciler.getEventCount();

// trigger reconciliation while waiting in reconciler
res = getResource();
Expand Down
Loading