chore: bump certified verifier to lean4:v4.34.0 and latest - #3159
Merged
Merged
Conversation
stephenh-axiom-xyz
requested review from
Golovanov399,
shuklaayush,
yi-sun and
zlangley
September 15, 2026 19:12
This comment has been minimized.
This comment has been minimized.
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This comment has been minimized.
This comment has been minimized.
stephenh-axiom-xyz
requested review from
jonathanpwang
and removed request for
Golovanov399 and
zlangley
September 17, 2026 13:49
| write_usize_as_u32(writer, whir.query_phase_pow_bits)?; | ||
| write_usize_as_u32(writer, whir.folding_pow_bits) | ||
| write_usize_as_u32(writer, whir.folding_pow_bits)?; | ||
| match whir.proximity { |
Contributor
There was a problem hiding this comment.
is this new for some reason?
Collaborator
Author
There was a problem hiding this comment.
We made the Lean vk match the Rust one at some point, which included removing some Lean fields and adding some Rust fields (like Whir proximity strategy)
jonathanpwang
approved these changes
Sep 17, 2026
jonathanpwang
left a comment
Contributor
There was a problem hiding this comment.
LGTM except not sure why there was a change in the WHIR test
Contributor
Note: cells_used metrics omitted because CUDA tracegen does not expose unpadded trace heights. Commit: 2a94f29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves INT-9471.
Summary
Update the certified verifier to the finalized recursion statement on
ws-fv'smainbranch. Refresh the generated C and Rust integration together so certified verification uses the split executable baseline and updated upstream wire format.openvm-certified-verifiercsrc/from thevm_verifyandvm_dump_prooflink closures usingleanprover/lean4:v4.34.0.build.rsand the C adapter for the new Lean toolchain and generated symbol names.VerificationBaseline.program_commit,initial_state, andinitial_pcindividually instead of recomputingapp_exe_commit().degree_multiplemetadata as required by the new decoder, and supportEntry::Challenge.afterChallengeplaceholder and duplicated symbolic layout fields.CI
WS_FV_REVand the shared Lean toolchain action.check_certified_verifier_c.shto Lake's nested build-trace inputs.Validation
The following checks passed with the temporary
v4.34.0-rc2toolchain and must be rerun after updating tov4.34.0:vm_verifyandvm_dump_proof; verified that vendored C matches their generated link closures byte-for-byte.30certified-verifier tests and both SDK certified-verifier tests with CUDA.cargo-openvmwithcuda,certified-verifierand passedtest_cli_stark_e2e_certified.-D warningsandcargo +nightly fmt --all -- --check.