Skip to content

feat(dhw): expose operation mode #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
redlegoman wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(dhw): expose operation mode #575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2610cb5
added getDomesticHotWaterOperatingMode which returns eco or commfort
redlegoman Jul 11, 2025
bce0564
Merge branch 'master' into master
CFenner Nov 12, 2025
9831ef7
Update test_TestForMissingProperties.py
CFenner Nov 12, 2025
b8819b9
Add test for domestic hot water operating mode
CFenner Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions PyViCare/PyViCareHeatingDevice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,10 @@ def getDomesticHotWaterMinTemperature(self):
def getDomesticHotWaterChargingActive(self):
return self.getProperty("heating.dhw.charging")["properties"]["active"]["value"]

@handleNotSupported
def getDomesticHotWaterOperatingMode(self):
return self.service.getProperty("heating.dhw.operating.modes.active")["properties"]["value"]["value"]

Comment on lines +165 to +168
Copy link
Copy Markdown
Member

@CFenner CFenner Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update the getDomesticHotWaterActiveMode function.

@handleAPICommandErrors
def setDomesticHotWaterTemperature(self, temperature):
""" Set the target temperature for domestic host water
Expand Down
1 change: 0 additions & 1 deletion tests/test_TestForMissingProperties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ def test_missingProperties(self):
'heating.dhw.hygiene.trigger',
'heating.dhw.temperature.hygiene',
'heating.dhw.operating.modes.off',
'heating.dhw.operating.modes.active',
'heating.dhw.operating.modes.comfort',
'heating.dhw.operating.modes.eco',
'heating.circuits.0.heating.roomInfluenceFactor',
Expand Down
3 changes: 3 additions & 0 deletions tests/test_Vitodens200W_B2HF.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,6 @@ def test_getSupplyPressure(self):

def test_getSupplyPressureUnit(self):
self.assertEqual(self.device.getSupplyPressureUnit(), 'bar')

def test_getDomesticHotWaterOperatingMode(self):
self.assertEqual(self.device.getDomesticHotWaterOperatingMode(), "balanced")