Conversation
|
User report here - thanks for this! I've been using the Python client for the last few days. It mostly works, but I occasionally get: Certainly, |
|
I've pushed a fix now, to the same branch. |
|
Just FYI, it seems like the maintainers of this repo don't respond to many pull requests, so I don't expect this to be merged. I've made a fork with this and several other improvements here: https://github.com/mdavis-xyz/opensky-api/tree/fork Install it with: |
|
Hi, I am a volunteer developer supporting the OpenSky team now with the Python API. I started to migrate the API for my own use case to oauth2 as shown in pull request 85. I would like to consider other opinions as well. |
This PR adds a few things.
None. This is a breaking change I suppose (though not covered by unit tests, I think). But returning None instead of an error makes this library extremely difficult to use. see Calling example returns None #72requests.Session(), so that the TLS and TCP connection is re-used across multiple requests, for performance reasons, and to simplify authentication handlingurl_postargument to an internal function, because it's for a GET request, so the name was misleadingpython test*.py(At first I thought the tests were passing, then I realised that they weren't actually being run.)Note that all the
get_statetests fail for me, even on the master branch. I think I don't have sufficiently privileged auth credentials.And now I'm getting 503 errors for most calls, so I can't be sure this is correct. That's why I've marked this PR as Draft. (I'm still uploading it so you can see, because I might not have time to get back to this for another week.)