Add go-tests job to monitoring-plugin by simonpasquier · Pull Request #76147 · openshift/release

simonpasquier · 2026-03-12T09:52:13Z

Will need openshift/monitoring-plugin#835 first

simonpasquier · 2026-03-12T10:12:09Z

/pj-rehearse

openshift-ci-robot · 2026-03-12T10:12:12Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jgbernalp · 2026-03-12T11:57:07Z

ci-operator/config/openshift/monitoring-plugin/openshift-monitoring-plugin-main.yaml

 - as: lint
  commands: |
-    make lint-frontend
+    make lint-frontend lint-backend && git diff --exit-code


lint-frontend changes the current directory. We probably need to fix this from the makefile side

in fact I had to change the approach because we need a Go-based image so I'm creating a new test.

simonpasquier · 2026-03-12T13:29:43Z

/hold

simonpasquier · 2026-03-13T09:04:21Z

/pj-rehearse pull-ci-openshift-monitoring-plugin-main-lint

openshift-ci-robot · 2026-03-13T09:04:24Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci-robot · 2026-03-13T09:07:17Z

@simonpasquier: job(s): pull-ci-openshift-monitoring-plugin-main-lint either don't exist or were not found to be affected, and cannot be rehearsed

simonpasquier · 2026-03-13T09:31:21Z

/pj-rehearse

openshift-ci-robot · 2026-03-13T09:31:24Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

simonpasquier · 2026-03-13T10:27:35Z

/pj-rehearse list

openshift-ci-robot · 2026-03-13T10:27:39Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

simonpasquier · 2026-03-13T10:32:20Z

/pj-rehearse pull-ci-openshift-monitoring-plugin-main-go-tests

openshift-ci-robot · 2026-03-13T10:32:23Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

simonpasquier · 2026-03-16T11:04:07Z

/pj-rehearse pull-ci-openshift-monitoring-plugin-main-go-tests

openshift-ci-robot · 2026-03-16T11:05:02Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

simonpasquier · 2026-03-16T11:41:47Z

/pj-rehearse

openshift-ci-robot · 2026-03-16T11:41:50Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

simonpasquier · 2026-03-16T12:32:08Z

/pj-rehearse

openshift-ci-robot · 2026-03-16T12:32:12Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

openshift-ci-robot · 2026-03-16T13:30:59Z

[REHEARSALNOTIFIER]
@simonpasquier: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-monitoring-plugin-main-go-tests	openshift/monitoring-plugin	presubmit	Presubmit changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci · 2026-03-16T13:36:14Z

@simonpasquier: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/monitoring-plugin/main/lint	`06d7dab`	link	unknown	`/pj-rehearse pull-ci-openshift-monitoring-plugin-main-lint`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

simonpasquier · 2026-03-16T14:25:41Z

/pj-rehearse

openshift-ci-robot · 2026-03-16T14:25:45Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

simonpasquier · 2026-03-16T14:47:08Z

/hold cancel

jgbernalp · 2026-03-16T14:49:30Z

/lgtm

jgbernalp · 2026-03-16T15:59:12Z

/approve

openshift-ci · 2026-03-16T16:03:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/monitoring-plugin/OWNERS~~ [jgbernalp]
~~ci-operator/jobs/openshift/monitoring-plugin/OWNERS~~ [jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

simonpasquier · 2026-03-17T08:25:50Z

/pj-rehearse ack

openshift-ci-robot · 2026-03-17T08:25:53Z

@simonpasquier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

openshift-ci bot requested review from etmurasaki and jgbernalp March 12, 2026 09:53

simonpasquier mentioned this pull request Mar 12, 2026

NO-JIRA: add golangci-lint openshift/monitoring-plugin#835

Merged

jgbernalp reviewed Mar 12, 2026

View reviewed changes

simonpasquier force-pushed the monitoring-plugin-lint-go branch from 06d7dab to 0c8ba0d Compare March 12, 2026 13:24

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 12, 2026

simonpasquier force-pushed the monitoring-plugin-lint-go branch 2 times, most recently from 6304bd3 to 570f39f Compare March 12, 2026 14:49

simonpasquier force-pushed the monitoring-plugin-lint-go branch from 570f39f to 6af1ddb Compare March 16, 2026 11:03

simonpasquier changed the title ~~Add lint-backend to monitoring-plugin~~ Add go-tests job to monitoring-plugin Mar 16, 2026

simonpasquier force-pushed the monitoring-plugin-lint-go branch from 6af1ddb to 3f62fbd Compare March 16, 2026 12:31

Add go-tests job to monitoring-plugin

7ef7519

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

simonpasquier force-pushed the monitoring-plugin-lint-go branch from 3f62fbd to 7ef7519 Compare March 16, 2026 13:27

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2026

openshift-ci bot assigned jgbernalp Mar 16, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2026

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2026

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 17, 2026

openshift-merge-bot bot merged commit d21a4ab into openshift:main Mar 17, 2026
16 checks passed

sairameshv pushed a commit to sairameshv/release that referenced this pull request Mar 23, 2026

Add go-tests job to monitoring-plugin (openshift#76147)

2b818db

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

Conversation

simonpasquier commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonpasquier commented Mar 12, 2026

Uh oh!

openshift-ci-robot commented Mar 12, 2026

Uh oh!

jgbernalp Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

simonpasquier Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

simonpasquier commented Mar 12, 2026

Uh oh!

simonpasquier commented Mar 13, 2026

Uh oh!

openshift-ci-robot commented Mar 13, 2026

Uh oh!

openshift-ci-robot commented Mar 13, 2026

Uh oh!

simonpasquier commented Mar 13, 2026

Uh oh!

openshift-ci-robot commented Mar 13, 2026

Uh oh!

simonpasquier commented Mar 13, 2026

Uh oh!

openshift-ci-robot commented Mar 13, 2026

Uh oh!

simonpasquier commented Mar 13, 2026

Uh oh!

openshift-ci-robot commented Mar 13, 2026

Uh oh!

simonpasquier commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

simonpasquier commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

simonpasquier commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simonpasquier commented Mar 16, 2026

Uh oh!

openshift-ci-robot commented Mar 16, 2026

Uh oh!

simonpasquier commented Mar 16, 2026

Uh oh!

jgbernalp commented Mar 16, 2026

Uh oh!

jgbernalp commented Mar 16, 2026

Uh oh!

openshift-ci bot commented Mar 16, 2026

Uh oh!

simonpasquier commented Mar 17, 2026

Uh oh!

openshift-ci-robot commented Mar 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

simonpasquier commented Mar 12, 2026 •

edited

Loading

openshift-ci bot commented Mar 16, 2026 •

edited

Loading