Skip to content

OCPBUGS-105399,OCPBUGS-105400: Remove TechPreview skips and event matchers from sigstore imagepolicy tests - #31521

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
amritansh1502:remove-sigstore-featureGate
Aug 21, 2026
Merged

OCPBUGS-105399,OCPBUGS-105400: Remove TechPreview skips and event matchers from sigstore imagepolicy tests#31521
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
amritansh1502:remove-sigstore-featureGate

Conversation

@amritansh1502

@amritansh1502 amritansh1502 commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The sigstore image policy tests have been moved to the[Suite:openshift/disruptive-longrunning] suite. This PR completes the cleanup by:

  • Removing the IsTechPreviewNoUpgrade runtime skip checks from both SigstoreImageVerification and SigstoreImageVerificationPKI test blocks (the [OCPFeatureGate:...] annotations already control test
    selection)
  • Removing 7 pathological event matchers that were only needed when the tests ran in the normal serial suite (the disruptive suite does not flag these events as pathological)

Summary by CodeRabbit

  • Tests
    • Streamlined image policy validation by removing obsolete prerequisite checks.
    • Retained existing handling for disconnected platform environments.
    • Removed outdated monitoring expectations associated with image-policy signature validation and image verification intervals.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug: https://redhat.atlassian.net/browse/OCPBUGS-105399

Summary

The sigstore image policy e2e tests (SigstoreImageVerification and SigstoreImageVerificationPKI) had runtime IsTechPreviewNoUpgrade skip checks that are redundant, the [OCPFeatureGate:...] annotations
in the test names already ensure these tests are only selected when the corresponding feature gate is active.
This removes both skip blocks so the tests execute correctly on any cluster where the feature gate is enabled.

Changes

  • Removed IsTechPreviewNoUpgrade skip from [OCPFeatureGate:SigstoreImageVerification] test block
  • Removed IsTechPreviewNoUpgrade skip from [OCPFeatureGate:SigstoreImageVerificationPKI] test block

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from deads2k and p0lyn0mial August 17, 2026 07:12
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 68fd4016-18af-4b75-8213-ead08df33a04

📥 Commits

Reviewing files that changed from the base of the PR and between d5ed70f and b841c63.

📒 Files selected for processing (2)
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
  • test/extended/imagepolicy/imagepolicy.go
💤 Files with no reviewable changes (2)
  • test/extended/imagepolicy/imagepolicy.go
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go

Included review availability: Your plan includes up to 8 reviews per rolling hour; 6 remain after this review.


Walkthrough

The change removes TechPreviewNoUpgrade skip checks from image-policy test suites. It also removes seven image-policy and Sigstore pathological event matchers and their helper implementations. Existing disconnected-platform checks and the two-node etcd matcher remain.

Changes

Image-policy test maintenance

Layer / File(s) Summary
Remove feature-gate prerequisite skips
test/extended/imagepolicy/imagepolicy.go
Removes TechPreviewNoUpgrade prerequisite skip checks from both image-policy test suites. Existing disconnected-platform checks and suite classifications remain unchanged.

Pathological matcher cleanup

Layer / File(s) Summary
Remove image-policy and Sigstore matchers
pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
Removes seven interval-scoped matcher registrations and their helper implementations. The two-node etcd endpoint configuration matcher remains registered.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b841c

The PR moves disruptive sigstore image-policy tests into the appropriate long-running suite and removes redundant skips and event matchers; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: deads2k, p0lyn0mial


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❓ Inconclusive The checked-out repository has no working-tree diff; the commit parent is available, but the required changed-code comparison has not yet been inspected. Inspect the commit diff against parent and verify process-level stdout or logging writes in all changed Go code.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed HEAD diff contains no added or changed Ginkgo title lines; remaining Describe, It, DescribeTable, and Entry titles are static and contain no run-dependent values.
Test Structure And Quality ✅ Passed The diff only removes TechPreview skip guards and obsolete pathological matchers; it adds no It blocks, assertions, resource operations, or waits, and existing tests retain cleanup and bounded Even...
Microshift Test Compatibility ✅ Passed The PR adds no Ginkgo tests; its diff only removes skip checks and pathological matchers. Existing image-policy tests are unchanged, so the new-test compatibility check does not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The diff adds no Ginkgo tests. Existing tests create ordinary pods and use APIs; no multi-node scheduling, affinity, node counting, failover, or rescheduling assumption was introduced.
Topology-Aware Scheduling Compatibility ✅ Passed The patch only deletes test skip logic and pathological-event matchers; it adds no deployment manifests, operator/controller scheduling code, or topology constraints.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR diff has zero additions and only removes skips and pathological matchers; it adds no Ginkgo tests or IPv4/external-connectivity code, and the existing IPv6 detection remains.
No-Weak-Crypto ✅ Passed The diff has 0 additions and 169 deletions; changed-line scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or non-constant-time secret comparison.
Container-Privileges ✅ Passed The PR only deletes code in two Go files; it adds no manifests or lines containing privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR diff contains only 169 deletions and no additions; it introduces no logging or sensitive-data output. Existing log calls are unchanged.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: removing TechPreview skips and event matchers from Sigstore image-policy tests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 17, 2026
@amritansh1502

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amritansh1502

Copy link
Copy Markdown
Contributor Author

cc @QiWang19

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The sigstore image policy e2e tests (SigstoreImageVerification and SigstoreImageVerificationPKI) had runtime IsTechPreviewNoUpgrade skip checks that are redundant, the [OCPFeatureGate:...] annotations
in the test names already ensure these tests are only selected when the corresponding feature gate is active.
This removes both skip blocks so the tests execute correctly on any cluster where the feature gate is enabled.

Changes

  • Removed IsTechPreviewNoUpgrade skip from [OCPFeatureGate:SigstoreImageVerification] test block
  • Removed IsTechPreviewNoUpgrade skip from [OCPFeatureGate:SigstoreImageVerificationPKI] test block

Summary by CodeRabbit

  • Tests
  • Updated image policy test coverage by removing obsolete feature-gate checks.
  • Preserved existing skips for disconnected and IPv6 environments.
  • PKI test cases now proceed directly after setup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amritansh1502 amritansh1502 changed the title OCPBUGS-105399: Remove TechPreviewNoUpgrade skip from sigstore imagepolicy tests OCPBUGS-105399,OCPBUGS-105400: Remove TechPreviewNoUpgrade skip from sigstore imagepolicy tests Aug 17, 2026
@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-105400, which is invalid:

  • expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The sigstore image policy e2e tests (SigstoreImageVerification and SigstoreImageVerificationPKI) had runtime IsTechPreviewNoUpgrade skip checks that are redundant, the [OCPFeatureGate:...] annotations
in the test names already ensure these tests are only selected when the corresponding feature gate is active.
This removes both skip blocks so the tests execute correctly on any cluster where the feature gate is enabled.

Changes

  • Removed IsTechPreviewNoUpgrade skip from [OCPFeatureGate:SigstoreImageVerification] test block
  • Removed IsTechPreviewNoUpgrade skip from [OCPFeatureGate:SigstoreImageVerificationPKI] test block

Summary by CodeRabbit

  • Tests
  • Updated image policy test coverage by removing obsolete feature-gate checks.
  • Preserved existing skips for disconnected and IPv6 environments.
  • PKI test cases now proceed directly after setup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 17, 2026
@amritansh1502

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-105400, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@saschagrunert

Copy link
Copy Markdown
Member

/retest

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@amritansh1502
amritansh1502 force-pushed the remove-sigstore-featureGate branch from f1e3c07 to 43d85fe Compare August 18, 2026 09:04
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@amritansh1502 amritansh1502 changed the title OCPBUGS-105399,OCPBUGS-105400: Remove TechPreviewNoUpgrade skip from sigstore imagepolicy tests OCPBUGS-105399,OCPBUGS-105400: Move sigstore imagepolicy tests to disruptive-longrunning suite and remove TechPreview skips Aug 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-105400, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The sigstore image policy e2e tests (SigstoreImageVerification and SigstoreImageVerificationPKI) had runtime IsTechPreviewNoUpgrade skip checks that are redundant, the [OCPFeatureGate:...] annotations
in the test names already ensure these tests are only selected when the corresponding feature gate is active.
This removes both skip blocks so the tests execute correctly on any cluster where the feature gate is enabled.

Changes

  • Removed IsTechPreviewNoUpgrade skip from [OCPFeatureGate:SigstoreImageVerification] test block
  • Removed IsTechPreviewNoUpgrade skip from [OCPFeatureGate:SigstoreImageVerificationPKI] test block

Summary by CodeRabbit

Tests

  • Updated image policy test coverage by removing obsolete feature-gate checks.
  • Preserved skips for disconnected and IPv6 environments.
  • Improved test classification for disruptive, long-running scenarios.
  • Enhanced monitoring of etcd endpoint configuration events.
  • Removed outdated validation and image-verification event patterns to improve test signal quality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

This pull request references Jira Issue OCPBUGS-105400, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The sigstore image policy tests trigger MCO rollouts (node reboots, config changes) which are inherently disruptive. This PR:

  • Moves both SigstoreImageVerification and SigstoreImageVerificationPKI test suites to [Suite:openshift/disruptive-longrunning]
  • Removes the redundant IsTechPreviewNoUpgrade runtime skip checks (the [OCPFeatureGate:...] annotations already control test selection)
  • Removes 7 pathological event matchers from duplicated_event_patterns.go that were only needed because the tests were incorrectly placed in the normal serial suite

Changes

  • test/extended/imagepolicy/imagepolicy.go: Added [Suite:openshift/disruptive-longrunning][Disruptive] to both test Describe blocks, removed TechPreview skip logic
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go: Removed event matchers for DeferringOperatorNodeUpdate, AnnotationChange, SetDesiredConfig, CrioReloaded, ConfigDriftMonitorStopped, AddSigtermProtection, RemoveSigtermProtection

Summary by CodeRabbit

  • Tests
  • Updated image policy test coverage by removing obsolete feature-gate checks.
  • Preserved existing skips for disconnected and IPv6 environments.
  • PKI test cases now proceed directly after setup.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…ning suite and remove TechPreview skips

Move SigstoreImageVerification and SigstoreImageVerificationPKI tests
to [Suite:openshift/disruptive-longrunning] since they trigger MCO
rollouts and node reboots. Remove redundant IsTechPreviewNoUpgrade
skip checks and the 7 pathological event matchers that were only
needed when the tests ran in the normal serial suite.
@amritansh1502
amritansh1502 force-pushed the remove-sigstore-featureGate branch from 43d85fe to b841c63 Compare August 18, 2026 09:12
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2026
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Note

The previously reviewed commits are no longer reachable (likely due to a force-push or rebase), so CodeRabbit is performing a full review instead of an incremental one. This review may take a little longer.

@amritansh1502 amritansh1502 changed the title OCPBUGS-105399,OCPBUGS-105400: Move sigstore imagepolicy tests to disruptive-longrunning suite and remove TechPreview skips OCPBUGS-105399,OCPBUGS-105400: Remove TechPreview skips and event matchers from sigstore imagepolicy tests Aug 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-105400, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.1.0) matches configured target version for branch (5.1.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The sigstore image policy tests have been moved to the[Suite:openshift/disruptive-longrunning] suite. This PR completes the cleanup by:

  • Removing the IsTechPreviewNoUpgrade runtime skip checks from both SigstoreImageVerification and SigstoreImageVerificationPKI test blocks (the [OCPFeatureGate:...] annotations already control test
    selection)
  • Removing 7 pathological event matchers that were only needed when the tests ran in the normal serial suite (the disruptive suite does not flag these events as pathological)

Summary by CodeRabbit

  • Tests
  • Streamlined image policy validation by removing obsolete prerequisite checks.
  • Retained existing handling for disconnected platform environments.
  • Removed outdated monitoring expectations associated with image-policy signature validation and image verification intervals.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@amritansh1502

Copy link
Copy Markdown
Contributor Author

@saschagrunert , could you please re review this when you have chance, i have included some more changes earlier i was not aware of those changes.

@saschagrunert saschagrunert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@amritansh1502

Copy link
Copy Markdown
Contributor Author

@cpmeadors , could you please take a look and approve the changes.

@openshift-trt

openshift-trt Bot commented Aug 18, 2026

Copy link
Copy Markdown

Job Failure Risk Analysis for sha: b841c63

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-ovn-fips Low
[sig-cli] Workloads client test ROSA-OSD_CCS-ARO-ConnectedOnly-Author:yinzhou-Medium-71273-Medium-71275-Validate user is able to extract rhel8 and rhel9 oc from the ocp payload
This test has passed 0.00% of 1 runs on release 4.23 [Aggregation:none Architecture:amd64 CGroupMode:v2 ContainerRuntime:crun FeatureSet:default Installer:ipi JobTier:standard LayeredProduct:none Network:ovn NetworkAccess:default NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:aws Procedure:none Scheduler:default SecurityMode:fips Suite:unknown Topology:ha Upgrade:none] in the last week.
---
[Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: services on a user defined primary network should be reachable through their cluster IP, node port and load balancer L2 primary UDN with custom network, cluster-networked pods, NodePort service [Suite:openshift/conformance/parallel]
This test has passed 0.00% of 1 runs on release 4.23 [Aggregation:none Architecture:amd64 CGroupMode:v2 ContainerRuntime:crun FeatureSet:default Installer:ipi JobTier:standard LayeredProduct:none Network:ovn NetworkAccess:default NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:aws Procedure:none Scheduler:default SecurityMode:fips Suite:unknown Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn Low
[sig-cli] Workloads client test ROSA-OSD_CCS-ARO-ConnectedOnly-Author:yinzhou-Medium-71273-Medium-71275-Validate user is able to extract rhel8 and rhel9 oc from the ocp payload
This test has passed 0.00% of 8 runs on release 4.23 [Aggregation:none Architecture:amd64 CGroupMode:v2 ContainerRuntime:runc FeatureSet:default Installer:ipi JobTier:standard LayeredProduct:none Network:ovn NetworkAccess:default NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:vsphere Procedure:none Scheduler:default SecurityMode:default Suite:unknown Topology:ha Upgrade:none] in the last week.
---
[Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: services on a user defined primary network should be reachable through their cluster IP, node port and load balancer L2 primary UDN with custom network, cluster-networked pods, NodePort service [Suite:openshift/conformance/parallel]
This test has passed 0.00% of 8 runs on release 4.23 [Aggregation:none Architecture:amd64 CGroupMode:v2 ContainerRuntime:runc FeatureSet:default Installer:ipi JobTier:standard LayeredProduct:none Network:ovn NetworkAccess:default NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:vsphere Procedure:none Scheduler:default SecurityMode:default Suite:unknown Topology:ha Upgrade:none] in the last week.
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi Low
[sig-cli] Workloads client test ROSA-OSD_CCS-ARO-ConnectedOnly-Author:yinzhou-Medium-71273-Medium-71275-Validate user is able to extract rhel8 and rhel9 oc from the ocp payload
This test has passed 0.00% of 17 runs on release 4.23 [Aggregation:none Architecture:amd64 CGroupMode:v2 ContainerRuntime:crun FeatureSet:default Installer:upi JobTier:standard LayeredProduct:none Network:ovn NetworkAccess:default NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:vsphere Procedure:none Scheduler:default SecurityMode:default Suite:unknown Topology:ha Upgrade:none] in the last week.
---
[Feature:NetworkSegmentation][ovn-kubernetes-ote][sig-network] Network Segmentation: services on a user defined primary network should be reachable through their cluster IP, node port and load balancer L2 primary UDN with custom network, cluster-networked pods, NodePort service [Suite:openshift/conformance/parallel]
This test has passed 0.00% of 17 runs on release 4.23 [Aggregation:none Architecture:amd64 CGroupMode:v2 ContainerRuntime:crun FeatureSet:default Installer:upi JobTier:standard LayeredProduct:none Network:ovn NetworkAccess:default NetworkStack:ipv4 OS:rhcos9 Owner:eng Platform:vsphere Procedure:none Scheduler:default SecurityMode:default Suite:unknown Topology:ha Upgrade:none] in the last week.

@QiWang19

Copy link
Copy Markdown
Member

/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning

@openshift-ci

openshift-ci Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d7ef850-9b2d-11f1-9459-3153f07ca67d-0

@cpmeadors

Copy link
Copy Markdown
Contributor

/approve

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amritansh1502, cpmeadors, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2026
@amritansh1502

Copy link
Copy Markdown
Contributor Author

/verified by @amritansh1502

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 20, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: This PR has been marked as verified by @amritansh1502.

Details

In response to this:

/verified by @amritansh1502

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@QiWang19

Copy link
Copy Markdown
Member

/retest-required

@openshift-ci

openshift-ci Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

@amritansh1502: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 6e93454 into openshift:main Aug 21, 2026
22 checks passed
@openshift-ci-robot

Copy link
Copy Markdown

@amritansh1502: Jira Issue Verification Checks: Jira Issue OCPBUGS-105399
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-105399 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Jira Issue Verification Checks: Jira Issue OCPBUGS-105400
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-105400 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400

Summary

The sigstore image policy tests have been moved to the[Suite:openshift/disruptive-longrunning] suite. This PR completes the cleanup by:

  • Removing the IsTechPreviewNoUpgrade runtime skip checks from both SigstoreImageVerification and SigstoreImageVerificationPKI test blocks (the [OCPFeatureGate:...] annotations already control test
    selection)
  • Removing 7 pathological event matchers that were only needed when the tests ran in the normal serial suite (the disruptive suite does not flag these events as pathological)

Summary by CodeRabbit

  • Tests
  • Streamlined image policy validation by removing obsolete prerequisite checks.
  • Retained existing handling for disconnected platform environments.
  • Removed outdated monitoring expectations associated with image-policy signature validation and image verification intervals.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants