OCPBUGS-105399,OCPBUGS-105400: Remove TechPreview skips and event matchers from sigstore imagepolicy tests - #31521
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 6 remain after this review. WalkthroughThe change removes ChangesImage-policy test maintenance
Pathological matcher cleanup
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to The PR moves disruptive sigstore image-policy tests into the appropriate long-running suite and removes redundant skips and event matchers; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/jira refresh |
|
@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
cc @QiWang19 |
|
Scheduling required tests: |
|
@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-105400, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid. 3 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-105400, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
f1e3c07 to
43d85fe
Compare
|
@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-105400, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid. 3 validation(s) were run on this bug
This pull request references Jira Issue OCPBUGS-105400, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…ning suite and remove TechPreview skips Move SigstoreImageVerification and SigstoreImageVerificationPKI tests to [Suite:openshift/disruptive-longrunning] since they trigger MCO rollouts and node reboots. Remove redundant IsTechPreviewNoUpgrade skip checks and the 7 pathological event matchers that were only needed when the tests ran in the normal serial suite.
43d85fe to
b841c63
Compare
|
Note The previously reviewed commits are no longer reachable (likely due to a force-push or rebase), so CodeRabbit is performing a full review instead of an incremental one. This review may take a little longer. |
|
@amritansh1502: This pull request references Jira Issue OCPBUGS-105399, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-105400, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@saschagrunert , could you please re review this when you have chance, i have included some more changes earlier i was not aware of those changes. |
|
Scheduling required tests: |
|
@cpmeadors , could you please take a look and approve the changes. |
|
Job Failure Risk Analysis for sha: b841c63
|
|
/payload-job periodic-ci-openshift-release-main-nightly-5.0-e2e-aws-disruptive-longrunning |
|
@QiWang19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1d7ef850-9b2d-11f1-9459-3153f07ca67d-0 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amritansh1502, cpmeadors, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by @amritansh1502 |
|
@amritansh1502: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Scheduling required tests: |
|
/retest-required |
|
@amritansh1502: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@amritansh1502: Jira Issue Verification Checks: Jira Issue OCPBUGS-105399 Jira Issue OCPBUGS-105399 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 Jira Issue Verification Checks: Jira Issue OCPBUGS-105400 Jira Issue OCPBUGS-105400 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Bug1: https://redhat.atlassian.net/browse/OCPBUGS-105399
Bug2: https://redhat.atlassian.net/browse/OCPBUGS-105400
Summary
The sigstore image policy tests have been moved to the
[Suite:openshift/disruptive-longrunning]suite. This PR completes the cleanup by:IsTechPreviewNoUpgraderuntime skip checks from bothSigstoreImageVerificationandSigstoreImageVerificationPKItest blocks (the[OCPFeatureGate:...]annotations already control testselection)
Summary by CodeRabbit