chore: [ROSAENG-62417] initialize fullsend per-repo installation - #316
Merged
openshift-merge-bot[bot] merged 2 commits intoJul 30, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (5)
📒 Files selected for processing (1)
WalkthroughAdds per-repository Fullsend configuration and a GitHub Actions workflow that dispatches repository events to Fullsend, handles authorized ChangesFullsend integration and pipeline update
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant GitHub
participant fullsend.yaml
participant Fullsend
participant PullRequest
GitHub->>fullsend.yaml: Issue or pull request event
fullsend.yaml->>Fullsend: Dispatch event and runtime configuration
Fullsend-->>fullsend.yaml: Run reusable agent workflow
GitHub->>fullsend.yaml: Authorized /fs-fix-stop comment
fullsend.yaml->>PullRequest: Apply fullsend-no-fix label and post instructions
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #316 +/- ##
=======================================
Coverage 65.03% 65.03%
=======================================
Files 23 23
Lines 1570 1570
=======================================
Hits 1021 1021
Misses 471 471
Partials 78 78 🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/fullsend.yaml (1)
22-29: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winScope the permission ceiling to
dispatch.Move the current permission map under
jobs.dispatch.permissionsand set top-levelpermissions: {}. This preserves the maximum required by nested Fullsend jobs while making least privilege explicit for future jobs; reusable workflows cannot elevate caller permissions. (docs.github.com)Proposed adjustment
-permissions: - actions: write - id-token: write - contents: write - issues: write - packages: read - pull-requests: write +permissions: {} jobs: dispatch: + permissions: + actions: write + id-token: write + contents: write + issues: write + packages: read + pull-requests: writeAs per path instructions, “Least privilege: minimize GITHUB_TOKEN permissions.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/fullsend.yaml around lines 22 - 29, Set the workflow-level permissions to an empty map, then move the existing permission entries under the `dispatch` job’s `permissions` key. Preserve all current permission values there so nested Fullsend jobs retain their required ceiling.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/fullsend.yaml:
- Around line 22-29: Set the workflow-level permissions to an empty map, then
move the existing permission entries under the `dispatch` job’s `permissions`
key. Preserve all current permission values there so nested Fullsend jobs retain
their required ceiling.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: c064bd92-a27c-4b6d-bc09-a75011271895
📒 Files selected for processing (12)
.fullsend/config.yaml.fullsend/customized/agents/.gitkeep.fullsend/customized/env/.gitkeep.fullsend/customized/harness/.gitkeep.fullsend/customized/plugins/.gitkeep.fullsend/customized/policies/.gitkeep.fullsend/customized/profiles/.gitkeep.fullsend/customized/providers/.gitkeep.fullsend/customized/schemas/.gitkeep.fullsend/customized/scripts/.gitkeep.fullsend/customized/skills/.gitkeep.github/workflows/fullsend.yaml
samanthajayasinghe
changed the title
Contributor
Author
|
/test validate |
3 similar comments
Contributor
Author
|
/test validate |
Contributor
Author
|
/test validate |
Contributor
Author
|
/test validate |
samanthajayasinghe
force-pushed
the
fullsend/scaffold-install
branch
from
July 29, 2026 00:21
4fb6c63 to
be2a98b
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/fullsend.yaml:
- Around line 1-2: Update the upstream URL in the managed-file header comment to
a valid current Fullsend scaffold path or stable commit, while preserving the
warning that the file should not be edited directly.
- Around line 88-89: Update the disabled-agent message in the gh pr comment step
to instruct users to satisfy the downstream fix gate by adding the fullsend-fix
label, while retaining the existing guidance about removing fullsend-no-fix or
using /fs-fix.
- Around line 22-28: Move the workflow-level permissions block to an empty
`permissions: {}` and define scoped permissions on the `jobs.dispatch`
reusable-workflow call. Retain only `contents: read`, `issues: write`, and
`pull-requests: write` for `stop-fix`, removing `actions: write`, `id-token:
write`, and `packages: read`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 65a030cc-f603-41da-838c-dfb4f40181f7
📒 Files selected for processing (12)
.fullsend/config.yaml.fullsend/customized/agents/.gitkeep.fullsend/customized/env/.gitkeep.fullsend/customized/harness/.gitkeep.fullsend/customized/plugins/.gitkeep.fullsend/customized/policies/.gitkeep.fullsend/customized/profiles/.gitkeep.fullsend/customized/providers/.gitkeep.fullsend/customized/schemas/.gitkeep.fullsend/customized/scripts/.gitkeep.fullsend/customized/skills/.gitkeep.github/workflows/fullsend.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- .fullsend/config.yaml
Contributor
Author
|
/test rosa-sts-e2e |
Contributor
Author
|
/test validate |
1 similar comment
Contributor
|
/test validate |
Contributor
|
/test rosa-sts-e2e |
dustman9000
reviewed
Jul 29, 2026
Member
You need to click into the prow jobs and look at the errors. Boilerplate is saying your git is not clean and you are modifying boilerplate managed files. |
Contributor
Author
|
/test validate |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
@samanthajayasinghe: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chamalabey, samanthajayasinghe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the fullsend scaffold files for per-repo installation.
Merge this PR to activate fullsend workflows.
Summary by CodeRabbit