-
Notifications
You must be signed in to change notification settings - Fork 47
mcpToolUI basic implementation for OpenShift Lightpseed + obs-mcp + Perses #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
iNecas
wants to merge
8
commits into
openshift:main
Choose a base branch
from
iNecas:ols-tool-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+862
−25
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e54a69a
OU-1264: mcpToolUI basic implementation
iNecas c285543
OU-1264: Use query for the dynamic panel name
iNecas bf75681
OU-1264: use show-timeseries tool for vis
iNecas 08bda3d
fix lint
iNecas 864b8d1
Update i18n
iNecas 0d9e9f5
OU-1264 - setup cypress component infra testing
iNecas 771cf79
OU-1264: component tests for ols-tool-ui/ShowTimeseries
iNecas 1df59f9
OU-1264: support for time window in show-timeseries tool
iNecas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { Labels } from '../../src/components/labels'; | ||
|
|
||
| describe('Labels', () => { | ||
| it('renders "No labels" when labels is empty', () => { | ||
| cy.mount(<Labels labels={{}} />); | ||
| cy.contains('No labels').should('be.visible'); | ||
| }); | ||
|
|
||
| it('renders "No labels" when labels is undefined', () => { | ||
| cy.mount(<Labels labels={undefined} />); | ||
| cy.contains('No labels').should('be.visible'); | ||
| }); | ||
|
|
||
| it('renders a single label', () => { | ||
| cy.mount(<Labels labels={{ app: 'monitoring' }} />); | ||
| cy.contains('app').should('be.visible'); | ||
| cy.contains('monitoring').should('be.visible'); | ||
| }); | ||
|
|
||
| it('renders multiple labels', () => { | ||
| const labels = { | ||
| app: 'monitoring', | ||
| env: 'production', | ||
| team: 'platform', | ||
| }; | ||
| cy.mount(<Labels labels={labels} />); | ||
|
|
||
| cy.contains('app').should('be.visible'); | ||
| cy.contains('monitoring').should('be.visible'); | ||
| cy.contains('env').should('be.visible'); | ||
| cy.contains('production').should('be.visible'); | ||
| cy.contains('team').should('be.visible'); | ||
| cy.contains('platform').should('be.visible'); | ||
| }); | ||
|
|
||
| it('renders label with key=value format', () => { | ||
| cy.mount(<Labels labels={{ severity: 'critical' }} />); | ||
| cy.get('.pf-v6-c-label').within(() => { | ||
| cy.contains('severity'); | ||
| cy.contains('='); | ||
| cy.contains('critical'); | ||
| }); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| export const AddToDashboardButton = ({ query, name, description }) => ( | ||
| <button | ||
| data-testid="add-to-dashboard" | ||
| data-name={name} | ||
| data-query={query} | ||
| data-description={description} | ||
| /> | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import React from 'react'; | ||
|
|
||
| export const OlsToolUIPersesWrapper = ({ children, initialTimeRange }) => ( | ||
| <div data-testid="perses-wrapper" data-time-range={JSON.stringify(initialTimeRange)}> | ||
| {children} | ||
| </div> | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import React from 'react'; | ||
|
|
||
| export const Panel = ({ definition, panelOptions }) => ( | ||
| <div data-testid="mock-panel"> | ||
| <div data-testid="panel-definition" data-definition={JSON.stringify(definition)} /> | ||
| {panelOptions?.extra && <div data-testid="panel-extra">{panelOptions.extra()}</div>} | ||
| </div> | ||
| ); | ||
|
|
||
| export const VariableProvider = ({ children }) => <>{children}</>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export const DataQueriesProvider = ({ children }) => children; | ||
| export const TimeRangeProviderBasic = ({ children }) => children; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // DurationString is used as a type-only import, so no runtime export needed | ||
| export type DurationString = string; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly just for reference on writing component tests.